Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67785 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 39418 invoked from network); 24 Jun 2013 06:31:02 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Jun 2013 06:31:02 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.91 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 108.166.43.91 smtp91.ord1c.emailsrvr.com Linux 2.6 Received: from [108.166.43.91] ([108.166.43.91:59974] helo=smtp91.ord1c.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 31/60-36899-4A7E7C15 for ; Mon, 24 Jun 2013 02:31:01 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp4.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id 240C21400EA for ; Mon, 24 Jun 2013 02:30:58 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp4.relay.ord1c.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id DE2261400CF for ; Mon, 24 Jun 2013 02:30:57 -0400 (EDT) Message-ID: <51C7E7A1.2050800@sugarcrm.com> Date: Sun, 23 Jun 2013 23:30:57 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: PHP Internals Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Fix for grapheme bug 61860 From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! I've started working on fixing bug #61860 (where grapheme case insensitive functions mess up offsets for complex case folding) and ended up rewriting the string search functions to use proper ICU API for that - USearch. All tests seem to be passing just fine, and it is what it should be doing from the start, but I do not completely trust that our tests there are full. So if someone uses grapheme string functions with real code & tests, could you please check out this pull: https://github.com/php/php-src/pull/362 And see if nothing breaks for you and notify me if anything does so I could add it to the tests. If nothing breaks, I'll commit it shortly. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227