Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67779
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.48 as permitted sender)
MIME-Version: 1.0
Sender: laruence@gmail.com
In-Reply-To: <CAP1Jc112Czzm_5qDBw5sNRuS46Bh=KseHhzdkhY6KUKEXpR82g@mail.gmail.com>
References: <CAAyV7nEx32ni3J0dOQprJCXd=4D06XwS0-Ro811OtqmPeEyYJg@mail.gmail.com>
 <CABBJUpcz3g6sWZR_K+p6fe0_nP7YZqW1XgZ54ktgA1KgD6xchg@mail.gmail.com>
 <CAAyV7nGFnDOzfR9B8PfgnbbG70ZVdwzx0XfZak9LoKuTSOkvEQ@mail.gmail.com>
 <51C38014.4090906@sugarcrm.com> <CAAyV7nGM5=e9bP7CtTjbUcnyk1m_C+MSDSEN5zYSbvt59wTSNQ@mail.gmail.com>
 <51C3C673.5060408@sugarcrm.com> <135ff3b963c3c90cd0e3ab1a69a1c37f@mail.gmail.com>
 <CAP1Jc112Czzm_5qDBw5sNRuS46Bh=KseHhzdkhY6KUKEXpR82g@mail.gmail.com>
Date: Sat, 22 Jun 2013 19:56:53 +0800
Message-ID: <CABBJUpdK1BCJ+Bd1LFR4-CyAd-kMR7twKBkfY8a_Ck=Yajs3Bg@mail.gmail.com>
To: Arnaud Le Blanc <arnaud.lb@gmail.com>
Cc: Andi Gutmans <andi@zend.com>, Stas Malyshev <smalyshev@sugarcrm.com>, 
	Anthony Ferrara <ircmaxell@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Disabling the GC during shutdown
From: laruence@php.net (Laruence)

On Sat, Jun 22, 2013 at 6:06 PM, Arnaud Le Blanc <arnaud.lb@gmail.com> wrote:
> Hi,
>
> This bug may be related (and has a reproducing script) :
> https://bugs.php.net/bug.php?id=63734
>
Hey:

   I probably has fixed this bug(actually, according to the reporter
this bug is due to Opcache):

   according to the latest feedback from the reporter:
 https://github.com/zendtech/ZendOptimizerPlus/issues/95#issuecomment-19854473

  "Incredible, but it works !
   Tested ZendOptimizerPlus latest version (ba6c5f3) : segfault
   Applied your patch : fully works"

  so,  I think this bug is probable like the previous one we already fixed:
  https://github.com/php/php-src/commit/e88cdaa0


thanks
>
> On Sat, Jun 22, 2013 at 4:41 AM, Andi Gutmans <andi@zend.com> wrote:
>>
>> >-----Original Message-----
>> >From: Stas Malyshev [mailto:smalyshev@sugarcrm.com]
>> >Sent: Thursday, June 20, 2013 8:20 PM
>> >To: Anthony Ferrara
>> >Cc: Laruence; internals@lists.php.net
>> >Subject: Re: [PHP-DEV] Disabling the GC during shutdown
>> >
>> >> However, that's not really fixing the situation either, as the zval is
>> >> still getting nuked (but only partially).
>> >
>> >If there's a memory overwrite or use-after-free is going on, this patch
>> is not a
>> >complete solution - it relies on the fact that "bad" data will be always
>> out of
>> >range of "good" data. I see no way to ensure that - so if there's an
>> overwrite
>> >that writes garbage inside the object there will be situations where the
>> >garbage looks exactly like a valid object ID and it will still crash, but
>> it would
>> >be significantly harder to reproduce.
>> >So I think before patching it we need to get to the root cause and figure
>> out
>> >why it happens and what causes it, instead of partially fixing the
>> symptom
>>
>> I agree with that. I think it'd be a mistake to submit any patch without
>> us understanding root cause.
>> We may cover up a bug which will resurface elsewhere...
>> Hopefully you can find a way to pin it down.
>>
>> Thanks for putting this much effort into it!
>> Andi
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
>



--
Laruence  Xinchen Hui
http://www.laruence.com/