Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67774 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 90828 invoked from network); 22 Jun 2013 04:37:17 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Jun 2013 04:37:17 -0000 Authentication-Results: pb1.pair.com header.from=andi@zend.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=andi@zend.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain zend.com from 209.85.223.169 cause and error) X-PHP-List-Original-Sender: andi@zend.com X-Host-Fingerprint: 209.85.223.169 mail-ie0-f169.google.com Received: from [209.85.223.169] ([209.85.223.169:46455] helo=mail-ie0-f169.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 74/18-36805-CF925C15 for ; Sat, 22 Jun 2013 00:37:17 -0400 Received: by mail-ie0-f169.google.com with SMTP id 10so21497582ied.28 for ; Fri, 21 Jun 2013 21:37:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:references:in-reply-to:mime-version:x-mailer:thread-index:date :message-id:subject:to:cc:content-type:x-gm-message-state; bh=E5RC/FOecWAveEiANWLIgYpYLRWJ6/ienERP5+mPaLA=; b=BTsMXcapKZN4w3plogBAOYpVZxLmBQggGrIhd7Y1iUs5xDLh3G0SPVTBpG2481MRyZ 0VoNrkzDlBdnGTYaWMNImy2Hxw4LKkJLvAYXqoHRuR2S8/rnSZM6Q+IS9X9fpRUvgtqr 6Kf592URouKiodhCY7g9Ybg7/+got9UZv/9j4xm94oliBnvOZjAFdHZYyeO41wHx3LWG Jt3NB++U4+/RLkc/lto2AGHqu9dcRXz1tDgdlTZJz6FHFl4/u8s7v2B51u4HKU41JSld rgwr7wrzd8GlqKeynD4K7lNE0QA8XAk64vrfARfTN+xgqPajzMgDVPymHTW5GD5N77oG 9+OA== X-Received: by 10.50.22.72 with SMTP id b8mr660209igf.17.1371875833195; Fri, 21 Jun 2013 21:37:13 -0700 (PDT) References: <51C38014.4090906@sugarcrm.com> <51C3C673.5060408@sugarcrm.com> In-Reply-To: <51C3C673.5060408@sugarcrm.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQHp9GqsamRfrNXp8kZv4cd0qFOBGAJAleB2AWPDl+MB90sMrQEnL9Y+AfaRmEuYxC+ZkA== Date: Fri, 21 Jun 2013 19:41:22 -0700 Message-ID: <135ff3b963c3c90cd0e3ab1a69a1c37f@mail.gmail.com> To: Stas Malyshev , Anthony Ferrara Cc: Laruence , internals@lists.php.net Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQmU03lpo2AtdHCR8teigvXCeRNmvQyK9HfKtyFP34Da1zeaQ2fK3mUcjgLGv5zclzgG3k7dp924YaQH7CUSb1lksqm90dHGmr0zTstJIKqiOPHaf67T+wCHGk85mVYBN2Aw5PdA Subject: RE: [PHP-DEV] Disabling the GC during shutdown From: andi@zend.com (Andi Gutmans) >-----Original Message----- >From: Stas Malyshev [mailto:smalyshev@sugarcrm.com] >Sent: Thursday, June 20, 2013 8:20 PM >To: Anthony Ferrara >Cc: Laruence; internals@lists.php.net >Subject: Re: [PHP-DEV] Disabling the GC during shutdown > >> However, that's not really fixing the situation either, as the zval is >> still getting nuked (but only partially). > >If there's a memory overwrite or use-after-free is going on, this patch is not a >complete solution - it relies on the fact that "bad" data will be always out of >range of "good" data. I see no way to ensure that - so if there's an overwrite >that writes garbage inside the object there will be situations where the >garbage looks exactly like a valid object ID and it will still crash, but it would >be significantly harder to reproduce. >So I think before patching it we need to get to the root cause and figure out >why it happens and what causes it, instead of partially fixing the symptom I agree with that. I think it'd be a mistake to submit any patch without us understanding root cause. We may cover up a bug which will resurface elsewhere... Hopefully you can find a way to pin it down. Thanks for putting this much effort into it! Andi