Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67738 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 64456 invoked from network); 19 Jun 2013 19:12:02 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Jun 2013 19:12:02 -0000 Authentication-Results: pb1.pair.com header.from=ircmaxell@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ircmaxell@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.175 as permitted sender) X-PHP-List-Original-Sender: ircmaxell@gmail.com X-Host-Fingerprint: 209.85.220.175 mail-vc0-f175.google.com Received: from [209.85.220.175] ([209.85.220.175:50382] helo=mail-vc0-f175.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BD/11-58445-28202C15 for ; Wed, 19 Jun 2013 15:12:02 -0400 Received: by mail-vc0-f175.google.com with SMTP id hr11so4053200vcb.20 for ; Wed, 19 Jun 2013 12:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=9TC/1W3f+3BtkVla3Rluo06/GvdRpUMyDtdZSLYtnJ4=; b=fyQapIBwA4nw6eKZ7W7cLdfGNLGwei97tQiKTbv8jTpW0+wzOMeO7IIeEdhjsc1M+y 2wUlci1Ju847Ki2Qd7joHR9c8/a3sJc3HIc84ylEZXYPcxSuPZ05zPpyD9K3bSjhlIzi 1Rtw9C/RHiG67Na4OCDluQBWfLdnIS3IdnHDALfnSb092MASKTM9deEXGD1cadq/wM0d YfzkKkDdSY7eyT8VQovYmo1u6RwEfX4c3/z+NX5noeAkYt2m1PJ3L3Eti7f6L9SdKI82 o5vJGXy2znh2qvSiHsw9HEclTyOAIZuWnpKGL6CQoVthK1JnperYn/W6IDX+4TLmDDIp qQzg== MIME-Version: 1.0 X-Received: by 10.58.22.74 with SMTP id b10mr1352762vef.47.1371668623071; Wed, 19 Jun 2013 12:03:43 -0700 (PDT) Received: by 10.58.199.76 with HTTP; Wed, 19 Jun 2013 12:03:42 -0700 (PDT) In-Reply-To: References: Date: Wed, 19 Jun 2013 15:03:42 -0400 Message-ID: To: =?ISO-8859-1?Q?Johannes_Schl=FCter?= Cc: "internals@lists.php.net" Content-Type: multipart/alternative; boundary=089e013c69e6071ee404df867d43 Subject: Re: [PHP-DEV] Disabling the GC during shutdown From: ircmaxell@gmail.com (Anthony Ferrara) --089e013c69e6071ee404df867d43 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Johannes, On Wed, Jun 19, 2013 at 2:43 PM, Johannes Schl=FCter wrote: > > > On Jun 19, 2013, at 19:46, Anthony Ferrara wrote: > > 1. Technically, all we need to do is force GC_G(gc_enabled) =3D 0 in > > shutdown. But we could also use zend_alter_ini_entry which has the same > > effect. The question comes is there any reason to go through the overhe= ad > > of altering the ini entry instead of the global directly? We do access > the > > global directly in other areas (but it's typically only set via ini)... > > If possible try to prevent users from shooting their feet by reenabling > via ini_set() or gc_collect_cycles() or such. Yeah, for that very reason I pushed it after the destructor functions. It could technically go down a step further below the output buffer as well, but I don't thing that's too necessary... Additionally, I have switched it to use the ini behavior setting... > > Additionally, considering that this does solve a segfault, is it worth > > nominating this for 5.3? Or is it too risky (or something else I'm > > missing)... > > See my previous mail to the list ... > That's why I actually called out 5.3 specifically. I'm not sold either way, but I can see why some would want to get this into the last release... And I could see why not... Thanks, Anthony --089e013c69e6071ee404df867d43--