Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:6772 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 53641 invoked by uid 1010); 3 Jan 2004 14:36:20 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 53607 invoked from network); 3 Jan 2004 14:36:20 -0000 Received: from unknown (HELO mail.zend.com) (192.117.235.230) by pb1.pair.com with SMTP; 3 Jan 2004 14:36:20 -0000 Received: (qmail 23508 invoked from network); 3 Jan 2004 14:36:18 -0000 Received: from guardian.zend.office (HELO andi-laptop.zend.com) (10.1.1.4) by int.zend.com with SMTP; 3 Jan 2004 14:36:18 -0000 Message-ID: <5.1.0.14.2.20040103163518.02483b78@127.0.0.1> X-Sender: andi@127.0.0.1 X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Sat, 03 Jan 2004 16:35:59 +0200 To: Simeon Koptelov ,internals@lists.php.net In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] Patch for adding elements to ArrayAccess From: andi@zend.com (Andi Gutmans) References: I don't think the ArrayAccess interface should work with the $a[] notation. I think E_ERROR is appropriate. Andi At 07:04 PM 1/3/2004 +0600, Simeon Koptelov wrote: >Hello internals, > >Could anyone who can commit to CVS review this patch and commit it if it's OK? >The patch was made for php5-200401021030 snapshot, the file >zend_object_handlers.c. It fixes the bug that using $a[] = 'Something' where >$a is instance of ArrayAccess will invoke offsetSet() with empty offset. >-- >PHP Internals - PHP Runtime Development Mailing List >To unsubscribe, visit: http://www.php.net/unsub.php