Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67716
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.42 as permitted sender)
MIME-Version: 1.0
Date: Mon, 17 Jun 2013 19:20:37 -0400
Message-ID: <CAL+t6cEMqyvV5EwWipOACouJiTwzyWzVvnce7WoMRetQNe+OAA@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c328601cf9f604df61d89b
Subject: PR 287 - added use_keys argument to array_filter() [Discussion]
From: theanomaly.is@gmail.com (Sherif Ramadan)

--001a11c328601cf9f604df61d89b
Content-Type: text/plain; charset=ISO-8859-1

I'm starting up a thread for discussion on Pull Request 287
https://github.com/php/php-src/pull/287 (allowing array keys to be passed
to the callback function of array_filter through a third optional boolean
argument). I would like to merge this into master and as discussed on IRC
it would probably be a good idea to startup a discussion and make sure
there aren't any objections or clarifications not yet voiced.

The patch has no BC because the third argument is optional and defaults to
false. Personally, I have always thought it would be a good idea to be able
to get the keys into the array_filter callback since I've stumbled across a
few scenarios where that would have made things easier.

I'm not sure if there are any particular down sides to this option being
added, but none that I can find. It currently passes all tests in master
and works as expected.

Thoughts, opinions, objections, concerns?


- Sherif

--001a11c328601cf9f604df61d89b--