Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:6771 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 29846 invoked by uid 1010); 3 Jan 2004 14:14:43 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 29822 invoked from network); 3 Jan 2004 14:14:43 -0000 Received: from unknown (HELO shiva.mind.de) (212.42.230.204) by pb1.pair.com with SMTP; 3 Jan 2004 14:14:43 -0000 Received: from [192.168.1.100] (p508EA28C.dip.t-dialin.net [80.142.162.140]) by shiva.mind.de (Postfix) with ESMTP id A716B97B66; Sat, 3 Jan 2004 15:14:26 +0100 (CET) Date: Sat, 3 Jan 2004 15:12:36 +0100 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <811052567828.20040103151236@marcus-boerger.de> To: Simeon Koptelov Cc: internals@lists.php.net In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Patch for adding elements to ArrayAccess From: helly@php.net (Marcus Boerger) Hello Simeon, Saturday, January 3, 2004, 2:04:45 PM, you wrote: > Hello internals, > Could anyone who can commit to CVS review this patch and commit it if it's OK? > The patch was made for php5-200401021030 snapshot, the file > zend_object_handlers.c. It fixes the bug that using $a[] = 'Something' where > $a is instance of ArrayAccess will invoke offsetSet() with empty offset. That's avery bad thing because you check all possible values. And meanwhile we already decided not to support $a[] with ArrayAccess. If you really want it then i would sugget that the index/offset passed to offsetSet is NULL. -- Best regards, Marcus mailto:helly@php.net