Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67707 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 76096 invoked from network); 14 Jun 2013 18:35:58 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 Jun 2013 18:35:58 -0000 Authentication-Results: pb1.pair.com smtp.mail=rasmus@lerdorf.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=rasmus@lerdorf.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.160.171 cause and error) X-PHP-List-Original-Sender: rasmus@lerdorf.com X-Host-Fingerprint: 209.85.160.171 mail-gh0-f171.google.com Received: from [209.85.160.171] ([209.85.160.171:35091] helo=mail-gh0-f171.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 57/1B-32590-C826BB15 for ; Fri, 14 Jun 2013 14:35:57 -0400 Received: by mail-gh0-f171.google.com with SMTP id f15so244744ghb.30 for ; Fri, 14 Jun 2013 11:35:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type :content-transfer-encoding:x-gm-message-state; bh=v+Pnn5Z91kReRUFE9UdiJ8DWUBINqe4WDJUzZWoR6k8=; b=BpnfpTtssKuR7syK+R/sSvtuzTZECr7b9TLq6rVxqX0XZpM0OcQT1XqBJ3eDbLVbdM Olk2PuIhXpy8yS6gVua4LPMv2te/C1+nH06qBxaYiwO7ZGknWi12fK3PN9+NhA3RLwvD C1BGm6EZkRlELcxc8Cadm5dk/cUKPSRqLI27/9frTbC8lPSFe8J+NU5mW3WmI25RzuE6 8teqQyo7coGPN3zmbaib2otaOZlglDcQg1s5+7oaiPjmIyyeHlAERv+WyclIHfw2IPsK 3qQl5Q/TXKUrldrXlPnVRhWdDB3GfHNPC6vK5bqDedDLtRwf5rOuT6VDEsUEXGQIOfs4 wJDA== X-Received: by 10.236.98.99 with SMTP id u63mr2229850yhf.157.1371234954089; Fri, 14 Jun 2013 11:35:54 -0700 (PDT) Received: from [192.168.200.148] (c-50-131-44-225.hsd1.ca.comcast.net. [50.131.44.225]) by mx.google.com with ESMTPSA id r41sm4997451yhc.12.2013.06.14.11.35.52 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Jun 2013 11:35:53 -0700 (PDT) Message-ID: <51BB6287.1020200@lerdorf.com> Date: Fri, 14 Jun 2013 11:35:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: PHP internals References: In-Reply-To: X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Gm-Message-State: ALoCoQm43vM6kF9ot7ow6SXFm/AjzGFbCKZsHgVidIzbCHCs1p9QItBhS8T5ISJkPgC6XIiPC7Ws Subject: Re: [PHP-DEV] Zend GC Recursion Elimination From: rasmus@lerdorf.com (Rasmus Lerdorf) On 06/14/2013 11:04 AM, Anthony Ferrara wrote: > When you run that on current master, you get a segfault stemming from the > zval_mark_grey() GC function. This segfault, or at least a segfault in zval_mark_grey(), has been reported a couple of times: https://bugs.php.net/64868 https://bugs.php.net/64827 https://bugs.php.net/61968 > So not a huge win overall, but can be significant in cases... > > What do you think? Is this worth pursuing further? is there a case I'm > missing, or some other reason we shouldn't do this? Since the reduced stack usage is likely to reduce the chances of hitting this segfault, which if it is the same one as in the bug reports, it is happening in the wild, then it is very much worthwhile to pursue this. -Rasmus