Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67705
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.49 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <51BA0041.3070509@sugarcrm.com>
References: <CAEZPtU69cXq4FCaumkmcrLDK3Fs+5YDsnuMxN1TLE=QDVmsX5w@mail.gmail.com>
	<51B984D2.4060401@sugarcrm.com>
	<CAEZPtU5e0U9GaYgasLBgGxmuXXEN-q-j2-hh9m0f78ejs0EcHA@mail.gmail.com>
	<51BA0041.3070509@sugarcrm.com>
Date: Thu, 13 Jun 2013 20:08:55 +0200
Message-ID: <CAEZPtU75kaza96sC9Kx5C8L-DN73PfmPkO-KPirWYzXRMnegKg@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: test bug60322
From: pierre.php@gmail.com (Pierre Joye)

On Thu, Jun 13, 2013 at 7:24 PM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Hi!
>
>> Fails on 5 boxes here.
>>
>> What's your settings?
>
> It would be much more useful to know what is *your* settings, since it
> is where the tests are failing. But never mind, I think I know where the
> problem is.

Yes, but I have to wait until the rest of the team wake up to get the
detailed settings and planed to post them here  :)

> The loop in the test:
>
> while(ob_get_clean());
>
> is wrong, since it would terminate at first empty buffer. So if you have
> multiple output buffers stacked (not sure how to create it with INI
> alone, maybe some extensions do that?) the buffers will not be cleaned
> properly by the time it gets to the var_dump, and thus the test would
> work wrong. I'll try to simulate this situation and rewrite the test.

Thanks! I will ask to run that test again and see if your commit fixes it.

Cheers,
-- 
Pierre

@pierrejoye | http://www.libgd.org