Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:6769 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 55750 invoked by uid 1010); 3 Jan 2004 13:16:43 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 55651 invoked from network); 3 Jan 2004 13:16:41 -0000 Received: from unknown (HELO jdi.jdimedia.nl) (212.204.192.51) by pb1.pair.com with SMTP; 3 Jan 2004 13:16:41 -0000 Received: from localhost (localhost [127.0.0.1]) by jdi.jdimedia.nl (8.12.10/8.12.10) with ESMTP id i03DGcWr022312; Sat, 3 Jan 2004 14:16:40 +0100 Date: Sat, 3 Jan 2004 14:16:38 +0100 (CET) X-X-Sender: derick@localhost To: Simeon Koptelov cc: internals@lists.php.net In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] Patch for adding elements to ArrayAccess From: derick@php.net (Derick Rethans) On Sat, 3 Jan 2004, Simeon Koptelov wrote: > Could anyone who can commit to CVS review this patch and commit it if it's OK? > The patch was made for php5-200401021030 snapshot, the file > zend_object_handlers.c. It fixes the bug that using $a[] = 'Something' where > $a is instance of ArrayAccess will invoke offsetSet() with empty offset. Can you please provide an unified diff (diff -u) against the latest CVS version? regards, Derick