Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67682 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 23854 invoked from network); 10 Jun 2013 18:24:07 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Jun 2013 18:24:07 -0000 Authentication-Results: pb1.pair.com header.from=ab@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=ab@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.73.107 as permitted sender) X-PHP-List-Original-Sender: ab@php.net X-Host-Fingerprint: 85.214.73.107 klapt.com Received: from [85.214.73.107] ([85.214.73.107:60841] helo=h1123647.serverkompetenz.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8B/D1-30264-6C916B15 for ; Mon, 10 Jun 2013 14:24:06 -0400 Received: by h1123647.serverkompetenz.net (Postfix, from userid 1006) id 993C46BC751; Mon, 10 Jun 2013 20:24:03 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on h1123647.serverkompetenz.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.5 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.2 Received: from [192.168.178.7] (dslb-088-067-234-098.pools.arcor-ip.net [88.67.234.98]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by h1123647.serverkompetenz.net (Postfix) with ESMTPSA id 92DA86BC742; Mon, 10 Jun 2013 20:24:00 +0200 (CEST) To: Stas Malyshev Cc: Pierre Joye , Gustavo Lopes , Derick Rethans , Johannes =?ISO-8859-1?Q?Schl=FCter?= , PHP internals In-Reply-To: <51B612D7.2060507@sugarcrm.com> References: <6dd0f0c5be06dc0713890f2000a0b551.squirrel@webmail.klapt.com> <51B612D7.2060507@sugarcrm.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 10 Jun 2013 20:23:46 +0200 Message-ID: <1370888626.2826.8.camel@ghost> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: #53437 From: ab@php.net (Anatol Belski) Hi Stas, On Mon, 2013-06-10 at 10:54 -0700, Stas Malyshev wrote: > Hi! > > > Stas, Johannes? We have to fix this crash, in one way or another. The > > current patch is good imo. > > I'm ok with this in 5.4 but I'd really like to fix the var_dump issue if > possible. I've reworked the patch before applying to 5.3 and 5.4 as it was suggested by Derick and Etienne. Also fixed the same for 5.5. Just pushed that and doing one more test round. All the properties are exported as int now, so that's the same in all the branches. With not portable I meant - for instance the 'days' property is long in the userspace, but is 64 bit internally. That means occasionally an overflow might happen. That's why the idea was to serialize it as a string, so it could work across platforms. Regards Anatol