Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:6768 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 40256 invoked by uid 1010); 3 Jan 2004 13:02:09 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 40187 invoked from network); 3 Jan 2004 13:02:05 -0000 Received: from unknown (HELO jungle) (217.118.79.9) by pb1.pair.com with SMTP; 3 Jan 2004 13:02:05 -0000 Received: from jungle ([127.0.0.1] helo=there ident=simeon) by jungle with smtp (Exim 3.35 #1 (Debian)) id 1AclTE-0004lI-00 for ; Sat, 03 Jan 2004 19:05:36 +0600 To: internals@lists.php.net Date: Sat, 3 Jan 2004 19:04:45 +0600 X-Mailer: KMail [version 1.3.2] MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="------------Boundary-00=_YB0XOFZMO3NMT75YQ0O4" Message-ID: Subject: Patch for adding elements to ArrayAccess From: xi@ngs.ru (Simeon Koptelov) --------------Boundary-00=_YB0XOFZMO3NMT75YQ0O4 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Hello internals, Could anyone who can commit to CVS review this patch and commit it if it's OK? The patch was made for php5-200401021030 snapshot, the file zend_object_handlers.c. It fixes the bug that using $a[] = 'Something' where $a is instance of ArrayAccess will invoke offsetSet() with empty offset. --------------Boundary-00=_YB0XOFZMO3NMT75YQ0O4 Content-Type: text/x-diff; charset="iso-8859-1"; name="patch.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch.diff" NDAzYzQwMwo8IAl6dmFsIHRtcDsKLS0tCj4gCXp2YWwgKmV4aXN0czsKNDA3LDQwOGM0MDcsNDE2 CjwgCQkJSU5JVF9aVkFMKHRtcCk7CjwgCQkJb2Zmc2V0ID0gJnRtcDsKLS0tCj4gCQkJTUFLRV9T VERfWlZBTCggb2Zmc2V0ICk7Cj4gCQkJWlZBTF9MT05HKCBvZmZzZXQsIDAgKTsKPiAKPiAJCQlN QUtFX1NURF9aVkFMKCBleGlzdHMgKTsKPiAJCQl6ZW5kX2NhbGxfbWV0aG9kX3dpdGhfMV9wYXJh bXMoICZvYmplY3QsIGNlLCBOVUxMLCAib2Zmc2V0ZXhpc3RzIiwgJmV4aXN0cywgb2Zmc2V0ICk7 Cj4gCQkJd2hpbGUoIGV4aXN0cy0+dHlwZSAhPSBJU19CT09MIHx8IGV4aXN0cy0+dmFsdWUubHZh bCAhPSAwICkKPiAJCQl7Cj4gCQkJCW9mZnNldC0+dmFsdWUubHZhbCsrOwo+IAkJCQl6ZW5kX2Nh bGxfbWV0aG9kX3dpdGhfMV9wYXJhbXMoICZvYmplY3QsIGNlLCBOVUxMLCAib2Zmc2V0ZXhpc3Rz IiwgJmV4aXN0cywgb2Zmc2V0ICk7Cj4gCQkJfQo= --------------Boundary-00=_YB0XOFZMO3NMT75YQ0O4--