Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67672 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 76908 invoked from network); 10 Jun 2013 11:24:43 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Jun 2013 11:24:43 -0000 Authentication-Results: pb1.pair.com header.from=ekneuss@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ekneuss@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.49 as permitted sender) X-PHP-List-Original-Sender: ekneuss@gmail.com X-Host-Fingerprint: 209.85.128.49 mail-qe0-f49.google.com Received: from [209.85.128.49] ([209.85.128.49:57509] helo=mail-qe0-f49.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 2D/4A-30264-A77B5B15 for ; Mon, 10 Jun 2013 07:24:42 -0400 Received: by mail-qe0-f49.google.com with SMTP id cz11so3918930qeb.22 for ; Mon, 10 Jun 2013 04:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=MVKe8beeaJVOUelp82lq3b6FpfDJXim42YfaRkQqjzM=; b=Nv0z8X2d2IdgLJ0BqqJIBWcD9giMhZqNfLie19YDGM5swkwb44t+YelMyyoGSBXdkP 0Ir7GgcOE+88QDbVFkji2dClUTaM6ufBVC40PbrK9EkdQCYa3akoS3dgn4scAOUUmCB5 8W9EXtO+oEGJ3tpaQqbJIBcztoUrVJfhfGIJC+4mcf2ZhQinqQLdYwKvd+F7CMnYpIzH tWWaELjbBqfOLF8yFIl9HrMtJZ9TUzVc0zvlVYX5ntVC/Cl1YCWZympRBOWun4GP21y6 dYkgJggVFCqJ7oe4fnVCSk4WX1mhCo3zb9Ka5pme/7AeIW/RW9AvEfkr+jQT4NY/4ujh JPwA== X-Received: by 10.49.62.33 with SMTP id v1mr9358791qer.53.1370863480074; Mon, 10 Jun 2013 04:24:40 -0700 (PDT) MIME-Version: 1.0 Sender: ekneuss@gmail.com Received: by 10.49.108.66 with HTTP; Mon, 10 Jun 2013 04:24:19 -0700 (PDT) In-Reply-To: References: <6dd0f0c5be06dc0713890f2000a0b551.squirrel@webmail.klapt.com> Date: Mon, 10 Jun 2013 13:24:19 +0200 X-Google-Sender-Auth: tUjsvO6_-S76q9SrGFZILJvVLzc Message-ID: To: Gustavo Lopes Cc: Anatol Belski , Derick Rethans , =?UTF-8?Q?Johannes_Schl=C3=BCter?= , Stas Malyshev , PHP internals Content-Type: multipart/alternative; boundary=e89a8f503642c3f7b004decb0660 Subject: Re: [PHP-DEV] Re: #53437 From: colder@php.net (Etienne Kneuss) --e89a8f503642c3f7b004decb0660 Content-Type: text/plain; charset=UTF-8 On Fri, Jun 7, 2013 at 9:27 PM, Gustavo Lopes wrote: > On Fri, 07 Jun 2013 14:06:11 +0200, Derick Rethans wrote: > > That's the one where conversion int <> string for serialization was >>> developed. It came into 5.5 with this patches (the originally proposed >>> patch is still attached to that ticket) >>> >>> http://git.php.net/?p=php-src.**git;a=commitdiff;h=** >>> 0ee71557ffd285552659b6aa37ea23**6e3bad493f >>> >> >> ["days"]=> >> - int(3) >> + string(1) "3" >> >> and >> >> - 'days' => 0, >> + 'days' => '0', >> >> I see this in all test cases - this is a BC break. >> > > I don't think this is a BC break, or at least it's a very minor. As I > understand it, when you read the property directly you still get an int: > > $iv = "2008-05-11T15:30:00Z/2007-03-**01T13:00:00Z"; > $di = new DateInterval($iv); > var_dump($di->days); //int(437) > > So this applies only to var_dump() output, serialization output and > something exotic as an array cast (which anyway has its own peculiarities > wrt the key type conversion -- or the absence of it). > > So if I understand correctly var_dump now indicates a different type than what accessing the property returns? Even if the change itself does not constitute a big BC break, this behavior is confusing and seems like a big no-no to me. -- Etienne Kneuss --e89a8f503642c3f7b004decb0660--