Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67671 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 74697 invoked from network); 10 Jun 2013 11:05:13 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Jun 2013 11:05:13 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.170 as permitted sender) X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.217.170 mail-lb0-f170.google.com Received: from [209.85.217.170] ([209.85.217.170:44166] helo=mail-lb0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CB/D9-30264-9E2B5B15 for ; Mon, 10 Jun 2013 07:05:13 -0400 Received: by mail-lb0-f170.google.com with SMTP id t13so1209861lbd.1 for ; Mon, 10 Jun 2013 04:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=4QMDQqbtXa7s7cNOIQED13d8HrnHVlwrr3c+2DHAw60=; b=JAeBQ0HR+VI3jSv7ShxwuYD9Zyfqa07fXUG2nITF/v8lX/Wfi3y83xx/iGmLdvz2BL 2raOMMJnFwxNfG0wIkLEzNnswerg5bBZyqgcB2ad/v2Vdsy6Z2sWodPqG3TuqZnf/0Bb zH95dCUHMZfPjkGNcoUTgC7KeFr1os4C9jc6oqrnjTwPcSYjGH6Pg3r0gvfbDyCt4P4j g5E70j6SQQXfLz08990iiIcJe2ZGN97uNRk9dCj00mipP3Z7r7LNXQG32ZK8BoZONBw/ qYmv19q4PEfWCG8G/bMNgLJy3lZX+dr1tJEYUZ0nCQs2AqOSeRRftY5kyPr+6UWlWvfs yNOQ== MIME-Version: 1.0 X-Received: by 10.152.20.66 with SMTP id l2mr2749049lae.30.1370862309897; Mon, 10 Jun 2013 04:05:09 -0700 (PDT) Received: by 10.112.138.135 with HTTP; Mon, 10 Jun 2013 04:05:09 -0700 (PDT) In-Reply-To: References: <6dd0f0c5be06dc0713890f2000a0b551.squirrel@webmail.klapt.com> Date: Mon, 10 Jun 2013 13:05:09 +0200 Message-ID: To: Gustavo Lopes Cc: Anatol Belski , Derick Rethans , =?ISO-8859-1?Q?Johannes_Schl=FCter?= , Stas Malyshev , PHP internals Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [PHP-DEV] Re: #53437 From: pierre.php@gmail.com (Pierre Joye) hi, On Fri, Jun 7, 2013 at 9:27 PM, Gustavo Lopes wrote: > On Fri, 07 Jun 2013 14:06:11 +0200, Derick Rethans wrote: > >>> That's the one where conversion int <> string for serialization was >>> developed. It came into 5.5 with this patches (the originally proposed >>> patch is still attached to that ticket) >>> >>> >>> http://git.php.net/?p=php-src.git;a=commitdiff;h=0ee71557ffd285552659b6aa37ea236e3bad493f >> >> >> ["days"]=> >> - int(3) >> + string(1) "3" >> >> and >> >> - 'days' => 0, >> + 'days' => '0', >> >> I see this in all test cases - this is a BC break. > > > I don't think this is a BC break, or at least it's a very minor. As I > understand it, when you read the property directly you still get an int: > > $iv = "2008-05-11T15:30:00Z/2007-03-01T13:00:00Z"; > $di = new DateInterval($iv); > var_dump($di->days); //int(437) > > So this applies only to var_dump() output, serialization output and > something exotic as an array cast (which anyway has its own peculiarities > wrt the key type conversion -- or the absence of it). I agree. Stas, Johannes? We have to fix this crash, in one way or another. The current patch is good imo. -- Pierre @pierrejoye | http://www.libgd.org