Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67648
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain nebm.ist.utl.pt from 193.136.128.21 cause and error)
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: "Anatol Belski" <ab@php.net>, "Derick Rethans" <derick@php.net>
Cc: =?utf-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>, "Stas
 Malyshev" <smalyshev@sugarcrm.com>, "PHP internals" <internals@lists.php.net>
References: <CAEZPtU7zDMYcbMvEehHXhaZY1-nUethxy2zpB+qiXjtNSDia6A@mail.gmail.com> <alpine.DEB.2.10.1306061204140.13444@whisky.home.derickrethans.nl> <CAEZPtU6cdQ9-XL_fsD5r4Ex2uKmgOPdZD_JFyqtGZwvfr6iNSw@mail.gmail.com> <alpine.DEB.2.10.1306071144530.13444@whisky.home.derickrethans.nl> <6dd0f0c5be06dc0713890f2000a0b551.squirrel@webmail.klapt.com> <alpine.DEB.2.10.1306071301500.13444@whisky.home.derickrethans.nl>
Date: Fri, 07 Jun 2013 21:27:30 +0200
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Organization: =?utf-8?Q?N=C3=BAcleo_de_Eng=2E_Biom=C3=A9di?=
 =?utf-8?Q?ca_do_I=2ES=2ET=2E?=
Message-ID: <op.wybpn4mmidpuyk@damnation.nl.lo.geleia.net>
In-Reply-To: <alpine.DEB.2.10.1306071301500.13444@whisky.home.derickrethans.nl>
User-Agent: Opera Mail/12.15 (Linux)
Subject: Re: [PHP-DEV] Re: #53437
From: glopes@nebm.ist.utl.pt ("Gustavo Lopes")

On Fri, 07 Jun 2013 14:06:11 +0200, Derick Rethans <derick@php.net> wrote:

>> That's the one where conversion int <> string for serialization was
>> developed. It came into 5.5 with this patches (the originally proposed
>> patch is still attached to that ticket)
>>
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=0ee71557ffd285552659b6aa37ea236e3bad493f
>
>    ["days"]=>
> -  int(3)
> +  string(1) "3"
>
> and
>
> -   'days' => 0,
> +   'days' => '0',
>
> I see this in all test cases - this is a BC break.

I don't think this is a BC break, or at least it's a very minor. As I  
understand it, when you read the property directly you still get an int:

$iv = "2008-05-11T15:30:00Z/2007-03-01T13:00:00Z";
$di = new DateInterval($iv);
var_dump($di->days); //int(437)

So this applies only to var_dump() output, serialization output and  
something exotic as an array cast (which anyway has its own peculiarities  
wrt the key type conversion -- or the absence of it).

-- 
Gustavo Lopes