Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67643 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 45309 invoked from network); 7 Jun 2013 12:06:15 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Jun 2013 12:06:15 -0000 Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.113.146.227 xdebug.org Linux 2.6 Received: from [82.113.146.227] ([82.113.146.227:45675] helo=xdebug.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 63/02-33815-6BCC1B15 for ; Fri, 07 Jun 2013 08:06:15 -0400 Received: from localhost (localhost [IPv6:::1]) by xdebug.org (Postfix) with ESMTPS id 8309ADE13F; Fri, 7 Jun 2013 13:06:11 +0100 (BST) Date: Fri, 7 Jun 2013 13:06:11 +0100 (BST) X-X-Sender: derick@whisky.home.derickrethans.nl To: Anatol Belski cc: =?UTF-8?Q?Johannes_Schl=C3=BCter?= , Stas Malyshev , PHP internals In-Reply-To: <6dd0f0c5be06dc0713890f2000a0b551.squirrel@webmail.klapt.com> Message-ID: References: <6dd0f0c5be06dc0713890f2000a0b551.squirrel@webmail.klapt.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] Re: #53437 From: derick@php.net (Derick Rethans) On Fri, 7 Jun 2013, Anatol Belski wrote: > On Fri, June 7, 2013 12:45, Derick Rethans wrote: > > On Thu, 6 Jun 2013, Pierre Joye wrote: > > > > > >> On Jun 6, 2013 6:03 PM, "Derick Rethans" wrote: > >> > >>> On Thu, 6 Jun 2013, Pierre Joye wrote: > >>> > >>>> The fix for #53437 is around for some time now. It full fills the > >>>> requirements described by Derick when we discussed the possible > >>>> fixes. > >>>> > >>>> Unless there are strong objections in the next couple of days, I > >>>> will ask Anatol to apply it on Monday. This is the last remaining > >>>> crash in 5.3/4 (already applied in 5.5) and needs to be fixed > >>>> asap. > >>> > >>> The last time I checked that it was using weird base64 encoding on > >>> stuff and I am absolutely against that. Where is the new patch? > >> > >> It is in 5.5 and no, it does not used that as stated in the > >> previous mails. > > > > That didn't answer my question though. I asked where the new patch > > was. > > That's the one where conversion int <> string for serialization was > developed. It came into 5.5 with this patches (the originally proposed > patch is still attached to that ticket) > > http://git.php.net/?p=php-src.git;a=commitdiff;h=0ee71557ffd285552659b6aa37ea236e3bad493f ["days"]=> - int(3) + string(1) "3" and - 'days' => 0, + 'days' => '0', I see this in all test cases - this is a BC break. Even though days is an int64, I think this should be a (platform) int and not a string in case it fits. No need to punish people on 64bit platforms. I'd even go as far as arguing that special_amount should be treated like that too. The deserializer needs to understand both types anyway. cheers, Derick -- http://derickrethans.nl | http://xdebug.org Like Xdebug? Consider a donation: http://xdebug.org/donate.php twitter: @derickr and @xdebug Posted with an email client that doesn't mangle email: alpine