Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67641 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 41110 invoked from network); 7 Jun 2013 11:11:23 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Jun 2013 11:11:23 -0000 Authentication-Results: pb1.pair.com header.from=ab@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=ab@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.73.107 as permitted sender) X-PHP-List-Original-Sender: ab@php.net X-Host-Fingerprint: 85.214.73.107 klapt.com Received: from [85.214.73.107] ([85.214.73.107:40055] helo=h1123647.serverkompetenz.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F2/41-33815-7DFB1B15 for ; Fri, 07 Jun 2013 07:11:23 -0400 Received: by h1123647.serverkompetenz.net (Postfix, from userid 33) id 7D20B6BC43D; Fri, 7 Jun 2013 13:11:15 +0200 (CEST) Received: from 94.216.54.153 (SquirrelMail authenticated user anatol@belski.net) by webmail.klapt.com with HTTP; Fri, 7 Jun 2013 13:11:15 +0200 Message-ID: <6dd0f0c5be06dc0713890f2000a0b551.squirrel@webmail.klapt.com> In-Reply-To: References: Date: Fri, 7 Jun 2013 13:11:15 +0200 To: "Derick Rethans" Cc: "Pierre Joye" , =?UTF-8?Q?=22Johannes_Schl=C3=BCter=22?= , "Stas Malyshev" , "PHP internals" Reply-To: "Anatol Belski" User-Agent: SquirrelMail/1.5.2 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] Re: #53437 From: ab@php.net ("Anatol Belski") Hi Derick, On Fri, June 7, 2013 12:45, Derick Rethans wrote: > On Thu, 6 Jun 2013, Pierre Joye wrote: > > >> On Jun 6, 2013 6:03 PM, "Derick Rethans" wrote: >> >>> >>> On Thu, 6 Jun 2013, Pierre Joye wrote: >>> >>> >>>> The fix for #53437 is around for some time now. It full fills the >>>> requirements described by Derick when we discussed the possible >>>> fixes. >>>> >>>> Unless there are strong objections in the next couple of days, I >>>> will ask Anatol to apply it on Monday. This is the last remaining >>>> crash in 5.3/4 (already applied in 5.5) and needs to be fixed asap. >>> >>> The last time I checked that it was using weird base64 encoding on >>> stuff and I am absolutely against that. Where is the new patch? >> >> It is in 5.5 and no, it does not used that as stated in the previous >> mails. > > That didn't answer my question though. I asked where the new patch was. > That's the one where conversion int <> string for serialization was developed. It came into 5.5 with this patches (the originally proposed patch is still attached to that ticket) http://git.php.net/?p=php-src.git;a=commitdiff;h=0ee71557ffd285552659b6aa37ea236e3bad493f http://git.php.net/?p=php-src.git;a=commitdiff;h=acd160530a3ef41403853fd983bef3082726b690 http://git.php.net/?p=php-src.git;a=commitdiff;h=add5420d89624550b1e6e72f960413ff7d0a69a2 Those are definitely crying to be backported into 5.3 and 5.4 as the corresponding tests are still crashy. Regards Anatol