Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67627 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 734 invoked from network); 4 Jun 2013 12:53:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Jun 2013 12:53:50 -0000 Authentication-Results: pb1.pair.com smtp.mail=johannes@schlueters.de; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=johannes@schlueters.de; sender-id=unknown Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.211.66 cause and error) X-PHP-List-Original-Sender: johannes@schlueters.de X-Host-Fingerprint: 217.114.211.66 config.schlueters.de Received: from [217.114.211.66] ([217.114.211.66:49300] helo=config.schlueters.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 7E/B0-21406-D53EDA15 for ; Tue, 04 Jun 2013 08:53:50 -0400 Received: from [192.168.2.20] (host-188-174-221-231.customer.m-online.net [188.174.221.231]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by config.schlueters.de (Postfix) with ESMTPSA id B5CCF65CE4; Tue, 4 Jun 2013 14:53:46 +0200 (CEST) To: Ferenc Kovacs Cc: PHP Internals In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Tue, 04 Jun 2013 14:55:34 +0200 Message-ID: <1370350534.2630.117.camel@guybrush> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] bring Exception::getTrace/getTraceAsString consistent with debug_backtrace From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=) On Tue, 2013-06-04 at 14:32 +0200, Ferenc Kovacs wrote: > What do you think about adding the $options and $limit arguments to those > two Exception methods? With debug_backtrace() adding those reduces the work the engine has to do while collecting the data, getTrace() is simply passing a pre-existing zval array to the user, so adding the logic their makes the implementation more complex and usage of these options slows down the operation (not that performance of those should really matter ;-) ) I'd prefer to keep it clean and simple :) johannes