Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67511
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <847803070.20130525005329@cypressintegrated.com>
References: <6b642a96e673c29dbaf2f239be15f7f6.squirrel@www.l-i-e.com>
	<519E8ADB.90202@sugarcrm.com>
	<CAH-PCH6F-upB9tbRotx5YGE4vyZwi0yi5+gOgs9QV3vu8KZryw@mail.gmail.com>
	<CAKUjMCXMTRvzJUFKFfbz3xV_E2gZ893CDNXjGbuoaKeuJbq2Rw@mail.gmail.com>
	<CAH-PCH5DGWSmfCjTJdaJtNS4+1N=hM12bGb8eGSuGuhRkmM58w@mail.gmail.com>
	<CACQesk4b+-xdXJ66naKKBh6PcN8M2GaDjyFmqwq_yKXqZa7rmg@mail.gmail.com>
	<847803070.20130525005329@cypressintegrated.com>
Date: Sat, 25 May 2013 13:01:49 +0200
Message-ID: <CAH-PCH4wmUf+aJTrwJd1vENh=pzPkWe2FEbtCTYmrT2XM0Xm-A@mail.gmail.com>
To: Sanford Whiteman <swhitemanlistens-software@cypressintegrated.com>
Cc: Etienne Kneuss <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b33cf2ea4a2af04dd88d7d3
Subject: Re: [PHP-DEV] Cannot call constructor
From: tyra3l@gmail.com (Ferenc Kovacs)

--047d7b33cf2ea4a2af04dd88d7d3
Content-Type: text/plain; charset=UTF-8

>
> This thread arose in response to what is undeniably a bad API
> authoring practice (first allowing full ctor override and later
> breaking BC without fanfare) Why are we letting the authors of
> Richard's library off the hook and putting it on ourselves to develop
> hacks? They obviously screwed up. What next? Do we let API consumers
> override a `final` that they don't like? Just use the right pattern in
> the first place. IMO.
>

I disagree.
It can be perfectly ok to allow the lib to be extended and the constructor
extended/replaced with a compatible one.
The problem is, that currently there is a scenario(lib didn't had a
constructor but now it does) which is a PITA.
Either the lib author needs to add an empty constructor into every class
just to make sure that it will be there to provide a painless upgrade when
the need arises for a constructor otherwise the lib consumer has to write
boilerplate to make sure that the parent constructor will be only called
whet ot is there.

Your example also shows an overengineered solution for a simple problem.
I think that this is QoL improvement which can be implemented to have a
reasonable gain without any cons.

--047d7b33cf2ea4a2af04dd88d7d3--