Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67490
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <519F2852.7040601@sugarcrm.com>
References: <519E797D.7040405@php.net>
	<519E7A88.5070208@sugarcrm.com>
	<CABFWAEqT_hfiSqP9wyNmuDMQfatzZMBygYZLbQXykECgce-0Eg@mail.gmail.com>
	<519F2852.7040601@sugarcrm.com>
Date: Fri, 24 May 2013 08:36:52 -0600
Message-ID: <CAFMT4NrwsoU5DVksjfsOjbDpHYmXTdKrtSbU9e3DU3fdNJcF_Q@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: Josh Davis <phpwnd@gmail.com>, "internals@lists.php.net" <internals@lists.php.net>, 
	Sebastian Bergmann <sebastian@php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Bug #64910: Line number of $e = new Exception vs. line
 number of throw $e
From: morrison.levi@gmail.com (Levi Morrison)

> Also, throwing new exception with previous is not the same as throwing
> the same exception twice.

Correct, but I've personally never thrown the same exception twice.
The only times I've thrown exceptions from catch blocks is to provide
a better exception or perhaps to abstract away something in the
implementation. For instance, if I hit a PDO exception in my data
access then I'll catch it somewhere higher in the structure and throw
a GatewayException instead. Likewise, if the data was coming from The
Cloud and I couldn't access it for some reason I'd throw the
GatewayException. This way when someone uses the gateway the
implementation doesn't leak. This is the only time I've thrown
exceptions in a catch block.

This is an interesting 'bug' or 'feature' or whatever you want to call
it. I wouldn't say the current way is wrong, but a naive approach
would have some interesting issues as well. More than anything I think
we just need to decide what we want the behavior to be a document the
resulting quirks.