Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67470
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ntlworld.com designates 81.103.221.47 as permitted sender)
To: <internals@lists.php.net>
Date: Fri, 24 May 2013 00:46:14 +0100
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
In-Reply-To: <519E797D.7040405@php.net>
Thread-Index: Ac5X8sPbtcm2UtgITeuUzDOAHNIkWQAG5pUg
Message-ID: <20130523234029.HCFX27539.aamtaout01-winn.ispmail.ntl.com@p2>
Subject: RE: [PHP-DEV] Bug #64910: Line number of $e = new Exception vs. line number of throw $e
From: jared.williams1@ntlworld.com ("Jared Williams")
References: <519E797D.7040405@php.net>

 

> -----Original Message-----
> From: Sebastian Bergmann [mailto:sebastian@php.net] 
> Sent: 23 May 2013 21:18
> To: internals@lists.php.net
> Subject: [PHP-DEV] Bug #64910: Line number of $e = new 
> Exception vs. line number of throw $e
> 
>  Hi!
> 
>  The error message that is created for an uncaught exception 
> as well  as the stacktrace of an exception list the number of 
> the line on which  the exception object was created. I would 
> expect this to be number of  the line on which the exception 
> is raised using the throw statement.
> 
>  Derick agrees with me that this is a bug. We propose to 
> update the file  and line properties of the exception object in the
>  zend_throw_exception_internal() and zend_throw_exception()
functions.
> 
>  Would such a change be accepted? Does it require an RFC?
> 

I agree that it should have been where the throw occurs, to allow for
an ExceptionFactory type use.

There is a method of making it better, but it's bit (rather a lot)
gnarly.

function createException($errno, $message, Exception $exception =
null)
{
  // Please forgive us for what we are about to do.
  // Fix up exceptions so they appear closer to where they are thrown
  $f = Closure::bind(
      function() {
        array_shift($this->trace);       // createException_
        $t = array_shift($this->trace);   // createException
        $this->line = $t['line'];
        $this->file = $t['file'];
        return $this;
      }, $this->createException_($errno, $message, $exception),
Exception::class);
  return $f();
}

private function createException_($errno, $message, Exception
$exception = null)
{
  switch ($errno)  {
    case 2002:
      return new ConnectException($message, $errno, $exception);

    case 2013:  // Connection dropped.
    case 2006:  // Gone away
      return new ConnectionDroppedException($message, $errno,
$exception);

    /*
    ....
    */

    default:
      return new DatabaseException($message, $errno, $exception);
  }
}

So

throw $obj->createException(...);  reports a more useful/accurate
location.

Jared