Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67466 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 33654 invoked from network); 23 May 2013 21:21:39 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 May 2013 21:21:39 -0000 Authentication-Results: pb1.pair.com smtp.mail=adam@adamharvey.name; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=adam@adamharvey.name; sender-id=pass Received-SPF: pass (pb1.pair.com: domain adamharvey.name designates 209.85.219.45 as permitted sender) X-PHP-List-Original-Sender: adam@adamharvey.name X-Host-Fingerprint: 209.85.219.45 mail-oa0-f45.google.com Received: from [209.85.219.45] ([209.85.219.45:61815] helo=mail-oa0-f45.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C2/C3-16824-2688E915 for ; Thu, 23 May 2013 17:21:39 -0400 Received: by mail-oa0-f45.google.com with SMTP id j6so5289457oag.32 for ; Thu, 23 May 2013 14:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamharvey.name; s=google; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=R7g35eGsrVrLw7jb3Nth4y4Se4c8Gpsge5veGoAbY6w=; b=mRqfhv3+LMHSZAe92tASjvpS7wBwU85A4C4FdH25b0apH69LBjF13SNL1dTP1iomE3 Orxu+HiYDImc1I0YWnin2e4EgX5GnmrORlpAQOhST7BFjejZDOoc6fe+a8gSYKHHiOKg hkUSeHkm9UltHElG3OFwRAPI4oGz6WzncFRBw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=R7g35eGsrVrLw7jb3Nth4y4Se4c8Gpsge5veGoAbY6w=; b=WiTFhOKcMJffPmxP1N7lB8VQp3NXXar19woBPlfngD1572elk6g/yOzt8K6TD+HKVo gtveqChfZ5FmdMjl9AOZKiIP9eJ2ml9ya33F5rEO/uwHFT1Z1mH+Br53cnqqpJ1w+Gno Clc3D4Mr4iwTOEay1IFkYpdER5Cp1Gz+bxO9LBW7XxzFcLAExpf7nUaI2myBCdW3A4G0 cVWD2abZJNzrwh/N2Bwn64O0oG4dzKgUf19tR3QU8QGUCozXr5ohWwdGnVETNNMElEok RxSihij7Bv7QsDSsEOvEklZbhRfEZ5dl/iq/24LdE2naW+bQ5t3+RkpjRhsrTTNpbyn3 4jMQ== X-Received: by 10.50.115.34 with SMTP id jl2mr35025igb.24.1369344095472; Thu, 23 May 2013 14:21:35 -0700 (PDT) MIME-Version: 1.0 Sender: adam@adamharvey.name Received: by 10.43.105.138 with HTTP; Thu, 23 May 2013 14:21:15 -0700 (PDT) In-Reply-To: References: Date: Thu, 23 May 2013 14:21:15 -0700 X-Google-Sender-Auth: hB6-25Qpj4mo6GX__gh5C8SUdhQ Message-ID: To: Nikita Popov Cc: PHP internals Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQm2bnxNriOKXga23BiRVqEx7/eVXce1GE1v0VmhBDdK9DdSOHj0uOMi+Tpi2uWf0AujWMYj Subject: Re: [PHP-DEV] Re: hash_pbkdf2 vs openssl_pbkdf2 From: aharvey@php.net (Adam Harvey) On 23 May 2013 14:11, Nikita Popov wrote: > If a bug is found we fix it. Proving several implementations of the same > thing to account for potential bugs isn't a good idea imho. It's not a very good example, I admit, but my point is that it's not as though they're actually the same code underneath. > If two functions for the same thing exist people need to wonder about which > one of them should be used, and in the worst case decide to use a pattern > like "if function1 exists call function1, if function2 exists call > function2, etc". Just like nowadays to generate a random string you usually > check something like four of five different functions. I think it's > preferable to have one and only one function in a default-enabled extension. I think that horse bolted about a decade ago. Assuming the OpenSSL version does actually work properly, I don't see why it's an issue. Adam