Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67463
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.163 as permitted sender)
Message-ID: <519E7A88.5070208@sugarcrm.com>
Date: Thu, 23 May 2013 13:22:32 -0700
Organization: SugarCRM
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: "internals@lists.php.net" <internals@lists.php.net>
CC: Sebastian Bergmann <sebastian@php.net>
References: <519E797D.7040405@php.net>
In-Reply-To: <519E797D.7040405@php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Bug #64910: Line number of $e = new Exception vs. line
 number of throw $e
From: smalyshev@sugarcrm.com (Stas Malyshev)

Hi!

>  Derick agrees with me that this is a bug. We propose to update the file
>  and line properties of the exception object in the
>  zend_throw_exception_internal() and zend_throw_exception() functions.
> 
>  Would such a change be accepted? Does it require an RFC?

On one hand, I think it makes sense - nobody really cares where the
exception was created... But there's one problem here:

try {
	//stuff
} catch(Exception $e) {
	$logger->log("Oops, exception!");
	throw $e;
}

If we update file/line here, we lose original exception information and
file/line in the exception becomes useless. Right now, since 99.99% of
the code does "throw new", it is always useful. So how you would propose
to solve this?

-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227