Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67447
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.43 as permitted sender)
MIME-Version: 1.0
Date: Sat, 18 May 2013 11:48:58 +0200
Message-ID: <CAF+90c8yTz14GoG1XPgvts=jKWZrhDZ_90nKbXL1_7ebKjDNgw@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0115ec1c33d9c004dcfb02de
Subject: hash_pbkdf2 vs openssl_pbkdf2
From: nikita.ppv@gmail.com (Nikita Popov)

--089e0115ec1c33d9c004dcfb02de
Content-Type: text/plain; charset=ISO-8859-1

Hi internals!

I just noticed that we added the PBKDF2 algorithm two times in PHP 5.5.
Once in the hash extension, once in the OpenSSL extension.

The hash_pbkdf2 function was added via this RFC:
https://wiki.php.net/rfc/hash_pbkdf2

The openssl_pbkdf2 function probably was not noticed at that time because
it was just commited, but not mentioned anywhere else (NEWS, UPGRADING,
etc). Only saw it in vrana's documentation updates just now. The relevant
commit is here: https://github.com/php/php-src/commit/f4847ef

It would be nice if we could have only one of those functions. I'm
currently tending towards the hash_ variant because of the commit message
of the openssl_ function:

> No easy way to put these in the hash extension since we don't really
support optional
> parameters to certain algorithms. Implemented in openssl for now since it
has it already
> and is pretty stable.
>
> Only SHA1 is confirmed to work as an algorithm but openssl has a
parameter so it can be
> changed in the future.

It seems that the author already would have preferred it in the hash
extension and that the openssl variant only works with sha1 (or was only
tested with it? not sure).

Nikita

--089e0115ec1c33d9c004dcfb02de--