Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67422
Return-Path: <nikita.ppv@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 72183 invoked from network); 13 May 2013 16:16:43 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 13 May 2013 16:16:43 -0000
Authentication-Results: pb1.pair.com smtp.mail=nikita.ppv@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=nikita.ppv@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.179 as permitted sender)
X-PHP-List-Original-Sender: nikita.ppv@gmail.com
X-Host-Fingerprint: 209.85.214.179 mail-ob0-f179.google.com  
Received: from [209.85.214.179] ([209.85.214.179:47181] helo=mail-ob0-f179.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 49/CE-55400-AE111915 for <internals@lists.php.net>; Mon, 13 May 2013 12:16:43 -0400
Received: by mail-ob0-f179.google.com with SMTP id xn12so6698311obc.24
        for <internals@lists.php.net>; Mon, 13 May 2013 09:16:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:x-received:in-reply-to:references:date:message-id
         :subject:from:to:cc:content-type;
        bh=1BfaMybV0zTmKCueUAIu5sGk+DzW1tNbkpFArmaYG3M=;
        b=T/5QgNUjaP81+p9B7ZxLfnQCdlJbzXJSNQ+cQ/vjeo7c7Ok9Updx7fPS6fC5Vh6sqc
         rJBZVRPMqL8jlHUo9tQtelej0FOl2RfSIGVGzj8z9t/fjbFUn1lvSxiWKAI/TjyhcfuV
         7YMVjx1/ud6imwDncI9Tpd2p7aDnmfs9TzASTbmqxUCO1zlDsAZh2TLyughrY89Z/5bT
         kobGhe6pt09K8GDl9EdXJ0LkcssM/CvBKRa26Kt46Q60t74dk248oQjE5/PM5lOkXyM9
         k8wFVS85tZh/5hMcXygLJhDV3hG0j7miL+mfJ4eKvz0JeMGnYvLFRjCMynJujjKvDWUr
         chnQ==
MIME-Version: 1.0
X-Received: by 10.60.95.71 with SMTP id di7mr13034693oeb.42.1368461800264;
 Mon, 13 May 2013 09:16:40 -0700 (PDT)
Received: by 10.182.49.136 with HTTP; Mon, 13 May 2013 09:16:40 -0700 (PDT)
In-Reply-To: <CA+9eiLtF3H=iu87udX8DNm87fWy3oofU1NyZOk7ALeKivRJiTg@mail.gmail.com>
References: <CAF+90c_PPTajBqs636f373DKF=hotrK1ObTojddxx=bxC3g16w@mail.gmail.com>
	<CA+9eiLvnV-i7Zp15oQ1EAzu2u8v_sc_Og8_bqHPBYWH9TyJ9cQ@mail.gmail.com>
	<CAF+90c_KfGWc7U5qA2Ey7FDqscvsRijAF16mqr+aG+561=WT9w@mail.gmail.com>
	<CA+9eiLuiDLYJtwxuUE8_1Het-S-NqaqDC_6gLm8scU253DTidw@mail.gmail.com>
	<CAF+90c9YV4P4MAHe8u2bq3FjVS0LxUtV9mfpni+4j0brvX7yNw@mail.gmail.com>
	<CA+9eiLtF3H=iu87udX8DNm87fWy3oofU1NyZOk7ALeKivRJiTg@mail.gmail.com>
Date: Mon, 13 May 2013 18:16:40 +0200
Message-ID: <CAF+90c9eTPM2ctqj9vGkBxsPSB+ommQnx2bT7e9aZ5VY_N+43A@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e01227ffe7ea9bb04dc9bd749
Subject: Re: [PHP-DEV] [RFC] Internal operator overloading and GMP improvements
From: nikita.ppv@gmail.com (Nikita Popov)

--089e01227ffe7ea9bb04dc9bd749
Content-Type: text/plain; charset=ISO-8859-1

On Mon, May 13, 2013 at 1:09 PM, Dmitry Stogov <dmitry@zend.com> wrote:

> Hi Nikita,
>
> I didn't get why do we need separate zend_std_compare() function.
> May be I just didn't look careful :)
>
Good point, that was not really necessary. I moved the code back into
compare_function.


> It would be great to look into the patch between master and current of
> your branch.
>
You can find a diff between master and my branch on the PR:
https://github.com/php/php-src/pull/342/files
The relevant diff for the compare handler is here:
https://github.com/php/php-src/pull/342/files#L2R1581

Nikita

--089e01227ffe7ea9bb04dc9bd749--