Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67417
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 209.85.212.42 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAF+90c_KfGWc7U5qA2Ey7FDqscvsRijAF16mqr+aG+561=WT9w@mail.gmail.com>
References: <CAF+90c_PPTajBqs636f373DKF=hotrK1ObTojddxx=bxC3g16w@mail.gmail.com>
	<CA+9eiLvnV-i7Zp15oQ1EAzu2u8v_sc_Og8_bqHPBYWH9TyJ9cQ@mail.gmail.com>
	<CAF+90c_KfGWc7U5qA2Ey7FDqscvsRijAF16mqr+aG+561=WT9w@mail.gmail.com>
Date: Mon, 13 May 2013 14:25:34 +0400
Message-ID: <CA+9eiLuiDLYJtwxuUE8_1Het-S-NqaqDC_6gLm8scU253DTidw@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec501625be05fdb04dc96ef88
Subject: Re: [PHP-DEV] [RFC] Internal operator overloading and GMP improvements
From: dmitry@zend.com (Dmitry Stogov)

--bcaec501625be05fdb04dc96ef88
Content-Type: text/plain; charset=UTF-8

Hi,

On Mon, May 13, 2013 at 1:24 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Mon, May 13, 2013 at 7:49 AM, Dmitry Stogov <dmitry@zend.com> wrote:
>
>> Hi Nikita,
>>
>> The patch looks quite good.
>> However, it must slow down each comparison operator (even if it compares
>> two integers).
>>
> In most cases it shouldn't, as the comparisons usually go through the
> fast_is_*_functions, which have special handling for integers and doubles.
> is_equal_function itself for example is only used in the implementation of
> ZEND_CASE (why? shouldn't we use the fast_ one here too?) and stuff like
> array_search.
>

Ahh, you are right :)


>
> I would suggest overloading of CMP operator instead of separate <, <=, ==,
>> !=, >, >=.
>>
>

> But yeah, that sounds like a better solution. The advantages I see:
> a) It will automatically work with sorting functions (and other stuff
> using compare_function). This is a pretty big plus.
> b) You don't have to implement the same (or similar) code for four (or
> six) operators.
> c) It (at least partially) also solves the concerns raised by Sara.
>

I'm glad, you are agree :)


> Would need an additional object handler though (as compare_objects works
> only on objects, so it's currently not possible to support something like
> $gmp == 0).
>
>
Or may be we may introduce additional opcode (or even pseudo-opcode)
ZEND_CMP to do it in the same way.
Also it may be better to use a table of callbacks for each overloaded
operand instead of single one that need to do switch anyway.

Thanks. Dmitry.


> Nikita
>

--bcaec501625be05fdb04dc96ef88--