Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67347
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <BLU0-SMTP164094802A24ECF73FFADB2E2BA0@phx.gbl>
References: <CAEe4Dn8qHRQnyVdsFGUdsKMLfG3t3R9tJuryfUdCKF-EvBaVvg@mail.gmail.com>
 <CAH-PCH69g-Vwi0_M-2A=CRFMDPNMEXzGGj=rjoDEGNWxViXK1w@mail.gmail.com> <BLU0-SMTP164094802A24ECF73FFADB2E2BA0@phx.gbl>
Date: Tue, 7 May 2013 21:07:46 +0200
Message-ID: <CALtuQzC3qBiGvZnWUZX0JenaBow3Cqmv6thEvAEF9iemta_Vqg@mail.gmail.com>
To: Bob Weinand <bobwei9@hotmail.com>
Cc: Ferenc Kovacs <tyra3l@gmail.com>, Thomas Anderson <zelnaga@gmail.com>, 
	PHP Mailing List Developers <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c343da95fa9304dc25896f
Subject: Re: [PHP-DEV] idea: letting the line number and file name be set via user_error
From: krebs.seb@gmail.com (Sebastian Krebs)

--001a11c343da95fa9304dc25896f
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

2013/5/7 Bob Weinand <bobwei9@hotmail.com>

>
> Am 7.5.2013 um 18:25 schrieb Ferenc Kovacs <tyra3l@gmail.com>:
>
> > On Tue, May 7, 2013 at 6:09 PM, Thomas Anderson <zelnaga@gmail.com>
> wrote:
> >
> >> If you do user_error('whatever') it'll show, as the line number for th=
at
> >> error, the line number on which that user_error() call is made.  It'd =
be
> >> nice if you could control the line number and file name that was
> displayed.
> >> eg.
> >>
> >> <?php
> >> function test() {
> >>    user_error('whatever');
> >> }
> >>
> >> test();
> >> ?>
> >>
> >> That'll say "Notice: whatever in ... on line 4" (ie. the line that the
> >> user_error is on) instead of "Notice: whatever in ... on line 7" (ie.
> the
> >> line that the call to the test() function is made).
> >>
> >> If the displayed line numbers could be controlled by user_error then
> >> debug_backtrace could be used to get the desired line number / file
> name to
> >> display.
> >>
> >
> > line 3, but I suppose that is just a typo on your part.
> > the default error handler reports the line when the actual error is
> > generated and it also provides a backtrace so you can see the callchain
> for
> > the execution.
> > I think that this is a sensible default, and allowing to fake that from
> the
> > userland would make the debugging of the problems harder, as many/most
> > people would look up the file:line number and would be surprised that
> there
> > is no E_USER_* thrown there.
> > Additionally I'm not sure how/where would you get your fake line number=
s.
> > You would either need to hardcode those in your application and make su=
re
> > that the reference and the actual content of your file is in sync (you
> will
> > screw yourself over sooner or later) or you would use __LINE__ + offset
> > which is still error prone..
> >
> > I didn't like this proposal.
> >
> > --
> > Ferenc Kov=E1cs
> > @Tyr43l - http://tyrael.hu
>
> And today we have the problem that we cannot use in any useful manner
> trigger_error in libraries, when we don't know where the error originates
> from.


Still don't get it:

if ($errorCond) {
  trigger_error();
}

The error orginates from at most one line before...


> You debug today trigger_error's in libraries with putting a
> debug_print_backtrace behind the trigger_error.
>

I use a debugger :X



> I think you should be able to track down the error source without
> manipulating any library code in the best case (yeah, there exist
> Exceptions (there you can add a backtrace) too, but you have to catch the=
m,
> if not your script will abort; but I only need a notice...)
>
> What I'm doing now is using my own error handler, add a "called at
> [line:file]" and output the string myself (via fwrite to STDERR). I don't
> think that this is the right way, this seems to me more like a temporary
> solution.
>
> Please change there something that makes it easier to debug
> trigger_error's notices. (But I don't know if only adding a third paramet=
er
> to trigger_error is enough...)
>
>
> Bob
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>


--=20
github.com/KingCrunch

--001a11c343da95fa9304dc25896f--