Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67335
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEe4Dn8qHRQnyVdsFGUdsKMLfG3t3R9tJuryfUdCKF-EvBaVvg@mail.gmail.com>
References: <CAEe4Dn8qHRQnyVdsFGUdsKMLfG3t3R9tJuryfUdCKF-EvBaVvg@mail.gmail.com>
Date: Tue, 7 May 2013 18:25:49 +0200
Message-ID: <CAH-PCH69g-Vwi0_M-2A=CRFMDPNMEXzGGj=rjoDEGNWxViXK1w@mail.gmail.com>
To: Thomas Anderson <zelnaga@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bd760c429957a04dc2345a7
Subject: Re: [PHP-DEV] idea: letting the line number and file name be set via user_error
From: tyra3l@gmail.com (Ferenc Kovacs)

--047d7bd760c429957a04dc2345a7
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, May 7, 2013 at 6:09 PM, Thomas Anderson <zelnaga@gmail.com> wrote:

> If you do user_error('whatever') it'll show, as the line number for that
> error, the line number on which that user_error() call is made.  It'd be
> nice if you could control the line number and file name that was displaye=
d.
> eg.
>
> <?php
> function test() {
>     user_error('whatever');
> }
>
> test();
> ?>
>
> That'll say "Notice: whatever in ... on line 4" (ie. the line that the
> user_error is on) instead of "Notice: whatever in ... on line 7" (ie. the
> line that the call to the test() function is made).
>
> If the displayed line numbers could be controlled by user_error then
> debug_backtrace could be used to get the desired line number / file name =
to
> display.
>

line 3, but I suppose that is just a typo on your part.
the default error handler reports the line when the actual error is
generated and it also provides a backtrace so you can see the callchain for
the execution.
I think that this is a sensible default, and allowing to fake that from the
userland would make the debugging of the problems harder, as many/most
people would look up the file:line number and would be surprised that there
is no E_USER_* thrown there.
Additionally I'm not sure how/where would you get your fake line numbers.
You would either need to hardcode those in your application and make sure
that the reference and the actual content of your file is in sync (you will
screw yourself over sooner or later) or you would use __LINE__ + offset
which is still error prone..

I didn't like this proposal.

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--047d7bd760c429957a04dc2345a7--