Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67292
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.45 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CABBJUpfZTiVH8AUNpknZC9y7uD4CP20KvuqtpZkVKfSDgRheAQ@mail.gmail.com>
References: <CABBJUpd40Rnq=Ux5viXeNwkSDO2oUYgT+VznWtU0W-7ZDz5ChA@mail.gmail.com>
	<CABBJUpfZTiVH8AUNpknZC9y7uD4CP20KvuqtpZkVKfSDgRheAQ@mail.gmail.com>
Date: Sat, 4 May 2013 14:49:42 +0200
Message-ID: <CAF+90c94mJED9=6vqRAuZMYNfxt6YtcnEuCrhsy2Beh=uBNG9Q@mail.gmail.com>
To: Laruence <laruence@php.net>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0149ca96c9981a04dbe3e685
Subject: Re: [PHP-DEV] Re: [PROPOSAL]Add second to callback of preg_replace_callback
From: nikita.ppv@gmail.com (Nikita Popov)

--089e0149ca96c9981a04dbe3e685
Content-Type: text/plain; charset=ISO-8859-1

On Sat, May 4, 2013 at 2:39 PM, Laruence <laruence@php.net> wrote:

> Hey:
>    Sorry for the delay,  the new patch, which make the second argument the
> regex array keys is attached.
>
>
>
> https://bugs.php.net/patch-display.php?bug_id=64730&patch=second_arg_rege_key.patch&revision=latest
>
>    with this patch,  preg_replace_callback will call user callback with two
> arguments, the first one is the same,  the second is the regex key if the
> regex is an array or NULL if the regex is a string.
>
>    then we can do something like:
>
>     $code = preg_replace_callback(
> array(
> "foo" => "/some very complex regex/",
> "bar" => "/another one/",
> ...
> ),
> function($matches, $idx)  {
>  switch ($idx) {
>   case 'foo'
>     ...
>   case 'bar':
>     ...
>  }
> },
> $code);
>
>
>   if no objections,  I will commit this patch after 5.5. 0 final release..
>
>   thanks
>

I object. If this were using the preg_replace_callback(Array, Array,
String) syntax [which is not practically possible due to ambiguity], I
would agree that this is a nice feature which makes the function consistent
with preg_replace and str_replace. But this implementation with some weird
additional identifier that you need to switch over makes absolutely no
sense to me and only complicated the API. Better to just use a loop for
this.

One thing that might be nicer API wise but without ambiguity is an
preg_replace_callback(['regex' => callback], $string) overload. Though
personally I'm not really a fan of doing overloads with completely
different argument types.

Nikita

--089e0149ca96c9981a04dbe3e685--