Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67211
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAFFuhJqiDasiMReBybDzkiCEXqCDySEjYmbieYctbnAc0Ya+dQ@mail.gmail.com>
References: <CABBJUpd40Rnq=Ux5viXeNwkSDO2oUYgT+VznWtU0W-7ZDz5ChA@mail.gmail.com>
	<CAFFuhJqiDasiMReBybDzkiCEXqCDySEjYmbieYctbnAc0Ya+dQ@mail.gmail.com>
Date: Tue, 30 Apr 2013 07:30:11 -0400
Message-ID: <CAAyV7nETgV+AkYo95tYnQUejnULFSSdruxKK1YVERM3sSM7gEQ@mail.gmail.com>
To: ALeX <lists.php@tx0.eu>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e01184abe0c4a9c04db9253ee
Subject: Re: [PHP-DEV] Re: [lists.php] [PHP-DEV] [PROPOSAL]Add second to
 callback of preg_replace_callback
From: ircmaxell@gmail.com (Anthony Ferrara)

--089e01184abe0c4a9c04db9253ee
Content-Type: text/plain; charset=ISO-8859-1

ALeX,


On Mon, Apr 29, 2013 at 5:53 PM, ALeX <lists.php@tx0.eu> wrote:

> what about patch preg_replace to accept callbacks?
>
> example:
> preg_replace(array(
>         "/pattern1(.*)/",
>         "/pattern2(.*)/"
>    ),
>    array(
>        function ($pat) { ... } ,
>         "replace"
>     )
> , ... );
>
>
There are some weird questions that come up with that. For example, if an
array item is an object that implements both __invoke() and __toString(),
which should be fired? Is it a string? Or a callback? What if I pass a
literal string "strlen", is that a callback, or a replacement?

The point is not that it's a bad idea and that we can't make a distinction,
but more that there are pretty severe edge-cases that we'd have to work
around, and if we don't get it right security could suffer significantly
(especially when user-input is allowed to be a replacement)...

Anthony

--089e01184abe0c4a9c04db9253ee--