Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67201
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.169 as permitted sender)
References: <CABBJUpd40Rnq=Ux5viXeNwkSDO2oUYgT+VznWtU0W-7ZDz5ChA@mail.gmail.com>
 <14729498.29703.1367255350466.JavaMail.mobile-sync@ieboh2>
Mime-Version: 1.0 (1.0)
In-Reply-To: <14729498.29703.1367255350466.JavaMail.mobile-sync@ieboh2>
Date: Tue, 30 Apr 2013 01:20:07 +0800
Message-ID: <745363686559186914@unknownmsgid>
To: Remi Collet <remi@fedoraproject.org>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [PROPOSAL]Add second to callback of preg_replace_callback
From: laruence@gmail.com (Xinchen Hui)

=E5=8F=91=E8=87=AA=E6=88=91=E7=9A=84 iPad

=E5=9C=A8 2013-4-30=EF=BC=8C1:09=EF=BC=8CRemi Collet <remi@fedoraproject.or=
g> =E5=86=99=E9=81=93=EF=BC=9A

> Le 29/04/2013 18:46, Laruence a =C3=A9crit :
>
>>   so I propose to add a second argument to callback(aim to php-5.5.1),
>
> Seems a useful fix to this problem (also encounter elsewhere)
>
>>  what do you think(of course, the second argument can also easily change
>> to  be the regex idx in the regex array)?
>
> I will prefer the idx (regex can be really long and complex string, and
> a minor change to a regex need to be also applied in the callback)
Yeah, I used regex just because it is easier to make a quick patch.
Using index need more functions signature changed

Will make that patch tomorrow

Thanks
>
> Esp if you can use a more simpler / meaningful value
>
> Ex:
>
> $code =3D preg_replace_callback(
> array(
> "foo" =3D> "/some very complex regex/",
> "bar" =3D> "/another one/",
> ...
> ),
> function($matches, $idx)  {
> switch ($idx) {
>  case 'foo'
>    ...
>  case 'bar':
>    ...
> }
> },
> $code);
>
>
> My 0,02=EF=BF=BD
>
> Remi.
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>