Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67200
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain fedoraproject.org from 212.27.42.5 cause and error)
Message-ID: <517EA8D1.2000108@fedoraproject.org>
Date: Mon, 29 Apr 2013 19:07:29 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130403 Thunderbird/17.0.5
MIME-Version: 1.0
To: PHP Internals <internals@lists.php.net>
References: <CABBJUpd40Rnq=Ux5viXeNwkSDO2oUYgT+VznWtU0W-7ZDz5ChA@mail.gmail.com>
In-Reply-To: <CABBJUpd40Rnq=Ux5viXeNwkSDO2oUYgT+VznWtU0W-7ZDz5ChA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [PROPOSAL]Add second to callback of preg_replace_callback
From: remi@fedoraproject.org (Remi Collet)

Le 29/04/2013 18:46, Laruence a écrit :

>    so I propose to add a second argument to callback(aim to php-5.5.1),

Seems a useful fix to this problem (also encounter elsewhere)

>   what do you think(of course, the second argument can also easily change
> to  be the regex idx in the regex array)?

I will prefer the idx (regex can be really long and complex string, and
a minor change to a regex need to be also applied in the callback)

Esp if you can use a more simpler / meaningful value

Ex:

$code = preg_replace_callback(
array(
"foo" => "/some very complex regex/",
"bar" => "/another one/",
...
),
function($matches, $idx)  {
 switch ($idx) {
  case 'foo'
    ...
  case 'bar':
    ...
 }
},
$code);


My 0,02€

Remi.