Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67192
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain kazik.de designates 209.85.210.41 as permitted sender)
MIME-Version: 1.0
Sender: alex@kazik.de
In-Reply-To: <1367248347.2723.1918.camel@guybrush>
References: <CAMUwpuTUVhZ23kCz8C0abU9FDzxrAat6y8mbOFKTd8gVifUV1Q@mail.gmail.com>
 <2284A817-6E8E-44AB-BEF2-2BA1923A3BAA@strojny.net> <1367248347.2723.1918.camel@guybrush>
Date: Mon, 29 Apr 2013 17:32:33 +0200
Message-ID: <CAFFuhJriZfTpG==d=cNCgO_UHDZq=UjxZ+ayXtutRPhEnm7gHA@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [lists.php] Re: [PHP-DEV] Continued try blocks
From: lists.php@tx0.eu (ALeX)

HI,

I also really don't like it.

if you have a try/catch within a for, will it continue the try or for?
(or have I to use "continue 2" to reach the for) At least use another
keyword to make it more clear that you don't want to continue a loop
at the beginning but a catch statement after the exception.

I would have solved your example like this:

try {
   try {
      $user = $repository->findById(123);
   } catch (NotFoundException $e) {
      $user = new User();
   }
   try {
      $user->setName($name);
   } catch (ValidationException $e) {
      $user->setName($this->stripInvalidChars($name));
   }
   $em->save($user);
   return true;
} catch (Exception $e) {
   return false;
}

I think that's more clear - but a few lines longer.

And it's probably more save, when the "$em->save($user);" throws a
NotFoundException exception then a new user will be created and then
(without saving) true is returned.