Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67177
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.181 as permitted sender)
MIME-Version: 1.0
Sender: amaury.bouchard@gmail.com
In-Reply-To: <517AD23A.7010505@heigl.org>
References: <CAMUwpuTUVhZ23kCz8C0abU9FDzxrAat6y8mbOFKTd8gVifUV1Q@mail.gmail.com>
 <517AD23A.7010505@heigl.org>
Date: Fri, 26 Apr 2013 21:52:16 +0200
Message-ID: <CAPaKmRmzPGRkiHzeEqF+WpzCcB1_5dit=SkLrm4sRqNePS1_nw@mail.gmail.com>
To: Andreas Heigl <andreas@heigl.org>
Cc: Julien Pauli <jpauli@php.net>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c24ed46fdee004db48e045
Subject: Re: [PHP-DEV] Continued try blocks
From: amaury@amaury.net (Amaury Bouchard)

--001a11c24ed46fdee004db48e045
Content-Type: text/plain; charset=ISO-8859-1

2013/4/26 Andreas Heigl <andreas@heigl.org>

> try {
>     $foo = $bar->getObject();
>     $foo->doSomething()
> } catch(Exception $e) {
>     continue // Or whatever shall be used
> }
>
> When $bar->getObject throws an Exception no $foo is set. So the next
> line will result in a "PHP Fatal error:  Call to a member function
> doSomething() on a non-object".
>

That's fine to me.

It's a software engineering problem you can solve easily:

 try {
     $foo = $bar->getObject();
     $foo->doSomething();
 } catch (ObjectCreationException $oce) {
     add_to_log('Unable to create object');
     throw $oce; // or do something else,
     // or just do nothing to exit from the try/catch block
 } catch (Exception $e) {
     add_to_log($e->getMessage());
     continue;
 }

The getObject() method should raise an ObjectCreationException, while the
doSomething() method could raise any other type of exception.
It's just a natural and smart way to use exceptions.


It could be solve differently:

 try {
     $foo = $bar->getObject();
     $foo->doSomething();
 } catch (NotImportantException $nie) {
     add_to_log($nie->getMessage());
     continue;
 } catch (Exception $e) {
     add_to_log($e->getMessage());
     throw $e; // or do something else,
     // or just do nothing to exit from the try/catch block
 }

If an expression raises a NotImportantException, it will not interrupt the
execution flow.

--001a11c24ed46fdee004db48e045--