Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67123 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 45317 invoked from network); 24 Apr 2013 11:14:57 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Apr 2013 11:14:57 -0000 Authentication-Results: pb1.pair.com smtp.mail=dsoria@gmx.net; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=dsoria@gmx.net; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmx.net designates 212.227.17.20 as permitted sender) X-PHP-List-Original-Sender: dsoria@gmx.net X-Host-Fingerprint: 212.227.17.20 mout.gmx.net Received: from [212.227.17.20] ([212.227.17.20:53327] helo=mout.gmx.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 0F/42-31471-BAEB7715 for ; Wed, 24 Apr 2013 07:14:52 -0400 Received: from mailout-de.gmx.net ([10.1.76.32]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0MHdb8-1UW33U3WF2-003Jx0 for ; Wed, 24 Apr 2013 13:14:48 +0200 Received: (qmail invoked by alias); 24 Apr 2013 11:14:48 -0000 Received: from p4FE3A4DB.dip0.t-ipconnect.de (EHLO achird.localdomain) [79.227.164.219] by mail.gmx.net (mp032) with SMTP; 24 Apr 2013 13:14:48 +0200 X-Authenticated: #235172 X-Provags-ID: V01U2FsdGVkX1+56DMgp1S5SJt/ME39q8adV56Js8E2ACl6pPcq+G VPu4n3CZfUIeCR Message-ID: <5177BEA3.6060104@gmx.net> Date: Wed, 24 Apr 2013 13:14:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 MIME-Version: 1.0 To: ramsey@php.net, "internals@lists.php.net" , pollita@php.net Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 Subject: ext/standard/tests/array/array_column_object_cast.phpt failing From: dsoria@gmx.net (David Soria Parra) Hi Sarah, Hi Ben, ext/standard/tests/array/array_column_object_cast.phpt is failing on PHP-5.5. I bisected to: 1a03bd5dee97a0f8b9e74b7f8db5231abd8cc7e4 is the first bad commit commit 1a03bd5dee97a0f8b9e74b7f8db5231abd8cc7e4 Author: Sara Golemon Date: Mon Apr 22 14:57:05 2013 -0700 Allow array_column() to take -1 as a valid value in third param Also do some cleanup and simplification to make this code more readable in the long term. Please have a look and run the test next time before you push. Thanks, David