Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67054 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 51513 invoked from network); 11 Apr 2013 18:06:20 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Apr 2013 18:06:20 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 173.203.6.155 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 173.203.6.155 smtp155.ord.emailsrvr.com Linux 2.6 Received: from [173.203.6.155] ([173.203.6.155:51136] helo=smtp155.ord.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 74/A2-36029-B9BF6615 for ; Thu, 11 Apr 2013 14:06:20 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp12.relay.ord1a.emailsrvr.com (SMTP Server) with ESMTP id 0912B2E00DD; Thu, 11 Apr 2013 14:06:17 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp12.relay.ord1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id C2E762E00AC; Thu, 11 Apr 2013 14:06:16 -0400 (EDT) Message-ID: <5166FB9A.3050406@sugarcrm.com> Date: Thu, 11 Apr 2013 14:06:18 -0400 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 MIME-Version: 1.0 To: =?UTF-8?B?T25kxZllaiBTdXLDvQ==?= CC: PHP Internals References: <1364337846.21443.58.camel@ghost> <51533A7A.8060204@gmx.net> <51536022.5080202@gmx.net> <1364836405.2855.16.camel@ghost> <5160B9F2.5080806@sugarcrm.com> <1365356692.2351.11.camel@atom.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] Re: libmagic 5.14 upgrade From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > Just a curious question – would it be possible to add some code > directly to upstream, so you wouldn't have to engulf > yet-another-library into PHP source tree? > > It's always a security nightmare to have various copies of libraries > at various places of the system. Not sure about what modifications are needed in this specific one but usually some patching is needed with libraries that work with files if we want to have them supporting streams, since by default they would just do open() and such. So in this case if we want them to support streams patching seems to be inevitable. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227