Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67052
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain sury.org designates 209.85.220.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <1365356692.2351.11.camel@atom.net>
References: <1364337846.21443.58.camel@ghost> <51533A7A.8060204@gmx.net>
 <CAEZPtU49vaV5YUKS6CZ-VrKQasCy7nC29pkdQA=rY+A1RP2Czg@mail.gmail.com>
 <51536022.5080202@gmx.net> <1364836405.2855.16.camel@ghost>
 <5160B9F2.5080806@sugarcrm.com> <1365356692.2351.11.camel@atom.net>
Date: Thu, 11 Apr 2013 17:27:49 +0200
Message-ID: <CALjhHG9LsVvsb2KTz7vBg5LA3R2PMgUp8sxz_4+ehKvP7Fk7iw@mail.gmail.com>
To: Anatoliy Belsky <ab@php.net>
Cc: Stas Malyshev <smalyshev@sugarcrm.com>, Pierre Joye <pierre.php@gmail.com>, 
	David Soria Parra <dsp@php.net>, =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>, 
	PHP Internals <internals@lists.php.net>, jpauli <jpauli@php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: libmagic 5.14 upgrade
From: ondrej@sury.org (=?UTF-8?B?T25kxZllaiBTdXLDvQ==?=)

Just a curious question =E2=80=93 would it be possible to add some code
directly to upstream, so you wouldn't have to engulf
yet-another-library into PHP source tree?

It's always a security nightmare to have various copies of libraries
at various places of the system.

Ondrej

On Sun, Apr 7, 2013 at 7:44 PM, Anatoliy Belsky <ab@php.net> wrote:
> Hi,
>
> Am Samstag, den 06.04.2013, 17:12 -0700 schrieb Stas Malyshev:
>
>> Looks ok, but I have one question - we have libmagic.patch file there
>> which as I understand is supposed to be diff between "our" libmagic and
>> upstream libmagic. But this patch does not update it. Is it intentional?
>> Will it be updated later?
>
>
> Of course I'll update libmagic.patch before commiting, that's just a
> diff command. Didn't do it as that's redundant to ext/fileinfo/libmagic
> part in the patch I've sent.
>
> Thanks for taking time.
>
> Anatol
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>



--=20
=EF=BB=BFOnd=C5=99ej Sur=C3=BD <ondrej@sury.org>