Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67048
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.45 as permitted sender)
MIME-Version: 1.0
Sender: laruence@gmail.com
In-Reply-To: <CA+9eiLsjK0wTT4L0UN9uJdSJgO8se3YDebZwSHycrqAJswJufQ@mail.gmail.com>
References: <CA+9eiLsjK0wTT4L0UN9uJdSJgO8se3YDebZwSHycrqAJswJufQ@mail.gmail.com>
Date: Thu, 11 Apr 2013 17:46:45 +0800
Message-ID: <CABBJUpf5Xv68jEUbTMSJbDtUB7-2DOpR7Hg00NmZO1sYWLOSMQ@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: PHP Internals <internals@lists.php.net>, Julien Pauli <jpauli@php.net>, 
	Rasmus Lerdorf <rasmus@lerdorf.com>, Zeev Suraski <zeev@zend.com>
Content-Type: multipart/alternative; boundary=089e01160d605b077404da12ab1f
Subject: Re: [PHP-DEV] OPcache optimizer improvement in PHP-5.5?
From: laruence@php.net (Laruence)

--089e01160d605b077404da12ab1f
Content-Type: text/plain; charset=UTF-8

Hey;
   I think it's a great idea, if all op_arrays in one script share the same
literals table, let's say it's main scope 's literals table.

   then we can make all class entry, function entry share the same constant
literal..

   image that, same class(function) only need to lookup once in one
script.. rest will all hits cache.... I think we can gain significant
peformance improve there.


 thanks


On Wed, Apr 10, 2013 at 7:57 PM, Dmitry Stogov <dmitry@zend.com> wrote:

> Hi,
>
> Recently, I've found that OPcache optimizer misses a lot of abilities,
> because it handles only one op_array at once. So it definitely can't
> perform any inter-function optimizations (e.g. inlining).
>
> Actually, it was not very difficult to switch to "script at once" approach.
> The attached patch demonstrates it and adds per script constants
> substitution explained in the following script
>
> <?php
> define("FOO", 1);
> function foo() {
>     echo FOO . "\n"; // optimizer will replace it with: echo "1\n";
> }
> ?>
>
> Of course, I ran the PHP test suite and it passed all the same tests.
> Personally, I think it's safe to include this patch into 5.5 and make a
> green light to some other advanced optimizations in 5.5. (e.g. conversion
> INIT_FCALL_BY_NAME into DO_FCALL).
>
> Any thoughts?
>
> Thanks. Dmitry.
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>



-- 
Laruence  Xinchen Hui
http://www.laruence.com/

--089e01160d605b077404da12ab1f--