Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67038 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 22028 invoked from network); 10 Apr 2013 16:46:45 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Apr 2013 16:46:45 -0000 Authentication-Results: pb1.pair.com smtp.mail=julienpauli@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=julienpauli@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.170 as permitted sender) X-PHP-List-Original-Sender: julienpauli@gmail.com X-Host-Fingerprint: 209.85.220.170 mail-vc0-f170.google.com Received: from [209.85.220.170] ([209.85.220.170:36798] helo=mail-vc0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D0/A6-21449-47795615 for ; Wed, 10 Apr 2013 12:46:44 -0400 Received: by mail-vc0-f170.google.com with SMTP id lf10so565024vcb.29 for ; Wed, 10 Apr 2013 09:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=b469P6iVk7+BNAFU+opcDRnUJYQywLEQlM4iQ9vnLt4=; b=pyxoXoAa2Hl5gaVuiLzCHgmnIP2m0bcq6Z1qvox9mxPMs8chIsoelDqrQj1Q9hGIfL FH8YXyumiu2CNss0zZKUi4huQEWIQ8u3hKzngQ20aVrPb736wSAVDKdDgRxYnJURE1qh 7cgUx+Y9tWLmbFBNtwQeygobk73KmH6WGliKQVRmGAEZZdf8GkW0Tc43DmUMoiUwTzSy trHwQOo9KE5mfGvjR0VawbH6KQCP9Ks23J8HlZcBm9QykEMTqYj0butIwZfJWqoiq2v9 dV7bs27VKsqr5ueTKCzpJ0wjVurKhYtDVeO1vz6KTqXurkqa+xZQICkGlgdCq0vzTZWe up6A== X-Received: by 10.220.104.20 with SMTP id m20mr2091525vco.70.1365612402151; Wed, 10 Apr 2013 09:46:42 -0700 (PDT) MIME-Version: 1.0 Sender: julienpauli@gmail.com Received: by 10.221.9.133 with HTTP; Wed, 10 Apr 2013 09:46:02 -0700 (PDT) In-Reply-To: References: <515BE6C2.7000801@sugarcrm.com> <515C9878.8060603@sugarcrm.com> <7848763017118166753@unknownmsgid> <1365159067.2152.2691.camel@guybrush> Date: Wed, 10 Apr 2013 18:46:02 +0200 X-Google-Sender-Auth: PGxbp-0GFBrEEQMta2fyCjuC_xs Message-ID: To: Hannes Magnusson Cc: =?ISO-8859-1?Q?Johannes_Schl=FCter?= , Pierre Joye , Pierrick Charron , Xinchen Hui , Leigh , Laruence , Stas Malyshev , Ferenc Kovacs , PHP Internals Content-Type: multipart/alternative; boundary=047d7b3437b821c6fa04da046a72 Subject: Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers From: jpauli@php.net (Julien Pauli) --047d7b3437b821c6fa04da046a72 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Fri, Apr 5, 2013 at 8:54 PM, Hannes Magnusson wrote: > On Fri, Apr 5, 2013 at 7:14 AM, Julien Pauli wrote: > > On Fri, Apr 5, 2013 at 12:51 PM, Johannes Schl=FCter < > johannes@schlueters.de> > > wrote: > >> > >> On Fri, 2013-04-05 at 08:01 +0200, Pierre Joye wrote: > >> > > stream_wrapper_unregister("http"); > >> > > stream_wrapper_register("http", "CurlStreamWrapper"); > >> > > and then stream_wrapper_restore("http") to go back to the core > >> > streams. > >> > > > >> > > >> > I wonder what one will do with open streams during the switches. Tha= t > >> > can't go well. > >> > >> For open streams there should be no issue - they hold the pointer to > >> their respective implementation. > >> > >> The issue I see is that libraries might change that for whatever reaso= ns > >> and not fix it up before passing control to some other library, thus > >> creating a hardly debugable mess. > > > > > > I'm feeling like we wont be able to make it stable for 5.5 final. > > > > Right, I don't think its worth actually fixing this for 5.5, the > current experiment should be removed by 5.5 and then the possibility > to register the curl stream wrapper from userland could be introduced > in 5.5.1 for example. > > For now, simply removing the config switch would be the quickest way > to achieve progress with minimal changes back and forth if anyone > wants to make that class. > > Beta3 has been taggued with curl wrappers, and with the new CURL_WRAPPERS_ENABLED constant :-p Do we all agree to remove that feature (meaning moving it to a branch, or somewhere for the interested developers to keep on making it stable) for 5.5 stable or no ? Julien.Pauli > -Hannes > --047d7b3437b821c6fa04da046a72--