Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67034
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain zend.com does not designate 209.85.220.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEZPtU6yBeEZgDty2Ly+YqG5AaOatRy6kNAR-_HcjVSZJqtbuw@mail.gmail.com>
References: <CA+9eiLsjK0wTT4L0UN9uJdSJgO8se3YDebZwSHycrqAJswJufQ@mail.gmail.com>
	<CAEZPtU6yBeEZgDty2Ly+YqG5AaOatRy6kNAR-_HcjVSZJqtbuw@mail.gmail.com>
Date: Wed, 10 Apr 2013 18:10:31 +0400
Message-ID: <CA+9eiLvKOYbYGqTz6d+jyt+RbG2=VnCd3cmwSKok_2fTkxzyNg@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
Cc: PHP Internals <internals@lists.php.net>, Julien Pauli <jpauli@php.net>, 
	Rasmus Lerdorf <rasmus@lerdorf.com>, Zeev Suraski <zeev@zend.com>
Content-Type: multipart/alternative; boundary=047d7b6dbc229b167004da023ba2
Subject: Re: [PHP-DEV] OPcache optimizer improvement in PHP-5.5?
From: dmitry@zend.com (Dmitry Stogov)

--047d7b6dbc229b167004da023ba2
Content-Type: text/plain; charset=UTF-8

Yes. And it's the reason I'm asking for agreement.

I may commit it into master and pecl, but it means that pecl branch is
going to be ahead of PHP-5.5.

Thanks. Dmitry.



On Wed, Apr 10, 2013 at 5:24 PM, Pierre Joye <pierre.php@gmail.com> wrote:

> hi Dmitry,
>
> On Wed, Apr 10, 2013 at 1:57 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> > Hi,
> >
> > Recently, I've found that OPcache optimizer misses a lot of abilities,
> > because it handles only one op_array at once. So it definitely can't
> perform
> > any inter-function optimizations (e.g. inlining).
> >
> > Actually, it was not very difficult to switch to "script at once"
> approach.
> > The attached patch demonstrates it and adds per script constants
> > substitution explained in the following script
> >
> > <?php
> > define("FOO", 1);
> > function foo() {
> >     echo FOO . "\n"; // optimizer will replace it with: echo "1\n";
> > }
> > ?>
> >
> > Of course, I ran the PHP test suite and it passed all the same tests.
> > Personally, I think it's safe to include this patch into 5.5 and make a
> > green light to some other advanced optimizations in 5.5. (e.g. conversion
> > INIT_FCALL_BY_NAME into DO_FCALL).
> >
> > Any thoughts?
>
> Mixed feeling, I like this "simple" optimization and the possible
> gains but 5.5 is very closed from RC.
>
> Cheers,
> --
> Pierre
>
> @pierrejoye
>

--047d7b6dbc229b167004da023ba2--