Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67019 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 29714 invoked from network); 9 Apr 2013 20:23:00 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Apr 2013 20:23:00 -0000 Authentication-Results: pb1.pair.com smtp.mail=ab@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=ab@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.73.107 as permitted sender) X-PHP-List-Original-Sender: ab@php.net X-Host-Fingerprint: 85.214.73.107 klapt.com Received: from [85.214.73.107] ([85.214.73.107:35994] helo=h1123647.serverkompetenz.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A2/C4-07032-F9874615 for ; Tue, 09 Apr 2013 16:23:00 -0400 Received: by h1123647.serverkompetenz.net (Postfix, from userid 33) id 8BC8570415E; Tue, 9 Apr 2013 22:22:52 +0200 (CEST) Received: from 94.216.56.150 (SquirrelMail authenticated user anatol@belski.net) by webmail.klapt.com with HTTP; Tue, 9 Apr 2013 22:22:52 +0200 Message-ID: <8f1769af0d904405e8791d6c6e2e4581.squirrel@webmail.klapt.com> Date: Tue, 9 Apr 2013 22:22:52 +0200 To: "internals" Cc: =?UTF-8?Q?=22Johannes_Schl=C3=BCter=22?= , "Stas Malyshev" , "Derick Rethans" , "Pierre Joye" Reply-To: ab@php.net User-Agent: SquirrelMail/1.5.2 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: DateTime for #53437 5.3/5.4 From: ab@php.net ("Anatol Belski") Hi, I just wanted to address again these two patches to be applied in 5.3/5.4 http://git.php.net/?p=php-src.git;a=commitdiff;h=0ee71557ffd285552659b6aa37ea236e3bad493f http://git.php.net/?p=php-src.git;a=commitdiff;h=fa3fc711d3fb54bf1746138ffcf7f46426921204 Both are in 5.5 already for some weeks, tested and proven to fix the crash in unserializing the DateTime object family. The important points do welcome this fix are - we deal with crash vs. bailout here - no other patch is available - a finer handling could introduce even more behaviour changes The history of this fix recalls the ticket from back more than 3 years ago https://bugs.php.net/53437 . The changes was considered OK by Derick and I'd really go on to apply those patches to 5.3+ as a clean die is in any case more vital than crash. That would fix the last known crash in 5.3/5.4, that might make very much sense to put those in. Thanks Anatol