Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:66995 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 88340 invoked from network); 7 Apr 2013 00:12:41 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Apr 2013 00:12:41 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.143 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 67.192.241.143 smtp143.dfw.emailsrvr.com Linux 2.6 Received: from [67.192.241.143] ([67.192.241.143:52791] helo=smtp143.dfw.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 60/C1-06893-7F9B0615 for ; Sat, 06 Apr 2013 19:12:40 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp4.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id 221063A0126; Sat, 6 Apr 2013 20:12:37 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp4.relay.dfw1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 467263A0137; Sat, 6 Apr 2013 20:12:36 -0400 (EDT) Message-ID: <5160B9F2.5080806@sugarcrm.com> Date: Sat, 06 Apr 2013 17:12:34 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: Anatol Belski CC: Pierre Joye , David Soria Parra , =?UTF-8?B?Sm9oYW5uZXMgU2NobMO8dGVy?= , PHP Internals , jpauli References: <1364337846.21443.58.camel@ghost> <51533A7A.8060204@gmx.net> <51536022.5080202@gmx.net> <1364836405.2855.16.camel@ghost> In-Reply-To: <1364836405.2855.16.camel@ghost> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: libmagic 5.14 upgrade From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > I've invested more time and here's almost cleaned up patch > > http://belski.net/phpz/finfo/finfo_5.14_10.patch.gz > > The tests pass, valgrind is happy, as well Windows. I've noticed no > behaviour change, except - as the data is updated and one might see > different (eventually better) results. Looks ok, but I have one question - we have libmagic.patch file there which as I understand is supposed to be diff between "our" libmagic and upstream libmagic. But this patch does not update it. Is it intentional? Will it be updated later? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227