Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:66979 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 77168 invoked from network); 5 Apr 2013 12:38:27 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 5 Apr 2013 12:38:27 -0000 Authentication-Results: pb1.pair.com smtp.mail=ab@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=ab@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.73.107 as permitted sender) X-PHP-List-Original-Sender: ab@php.net X-Host-Fingerprint: 85.214.73.107 klapt.com Received: from [85.214.73.107] ([85.214.73.107:51880] helo=h1123647.serverkompetenz.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C6/63-57919-EB5CE515 for ; Fri, 05 Apr 2013 07:38:26 -0500 Received: by h1123647.serverkompetenz.net (Postfix, from userid 1006) id 18C6A6FCBED; Fri, 5 Apr 2013 14:38:18 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on h1123647.serverkompetenz.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.5 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.1 Received: from [192.168.178.7] (dslb-094-216-049-011.pools.arcor-ip.net [94.216.49.11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by h1123647.serverkompetenz.net (Postfix) with ESMTPSA id 4BD216FCBEC; Fri, 5 Apr 2013 14:38:16 +0200 (CEST) To: Stas Malyshev Cc: Pierre Joye , David Soria Parra , Johannes =?ISO-8859-1?Q?Schl=FCter?= , PHP Internals , jpauli In-Reply-To: <1364836405.2855.16.camel@ghost> References: <1364337846.21443.58.camel@ghost> <51533A7A.8060204@gmx.net> <51536022.5080202@gmx.net> <1364836405.2855.16.camel@ghost> Content-Type: text/plain; charset="UTF-8" Date: Fri, 05 Apr 2013 14:38:15 +0200 Message-ID: <1365165495.2855.27.camel@ghost> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: libmagic 5.14 upgrade From: ab@php.net (Anatol Belski) Stas, how does it look with this one? Please let me know whether it's ok for 5.4. I would go with master otherwise. Thanks Anatol On Mon, 2013-04-01 at 19:13 +0200, Anatol Belski wrote: > Stas, > > I've invested more time and here's almost cleaned up patch > > http://belski.net/phpz/finfo/finfo_5.14_10.patch.gz > > The tests pass, valgrind is happy, as well Windows. I've noticed no > behaviour change, except - as the data is updated and one might see > different (eventually better) results. > > Please take a look. > > Regards > > Anatol > > On Wed, 2013-03-27 at 22:09 +0100, David Soria Parra wrote: > > On 03/27/2013 09:35 PM, Pierre Joye wrote: > > > > > We have done that many times in the past for 5.3 and 5.4. It is > > > relatively risk free. Even more for 5.5 during beta phase. It does not > > > add new features but fixes bugs. > > > > > > The good side effect is that we can test it well with 5.5 and back > > > port to 5.3/4 later. > > > > I consider it a feature and not a necessary bugfix. In addition anatoly > > is saying that there are still problems with the patch. Both are reasons > > for me to believe that upgrading it 1-1.5 month before a final is not > > worth the risk. I would prefer to be more strict about the "feature > > freeze" than we were with 5.3 and 5.4. > > > > David > > > > > > >