Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:66961 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 94626 invoked from network); 4 Apr 2013 19:52:13 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Apr 2013 19:52:13 -0000 Authentication-Results: pb1.pair.com smtp.mail=hannes.magnusson@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=hannes.magnusson@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.48 as permitted sender) X-PHP-List-Original-Sender: hannes.magnusson@gmail.com X-Host-Fingerprint: 209.85.215.48 mail-la0-f48.google.com Received: from [209.85.215.48] ([209.85.215.48:52327] helo=mail-la0-f48.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F5/1C-35962-CE9DD515 for ; Thu, 04 Apr 2013 14:52:13 -0500 Received: by mail-la0-f48.google.com with SMTP id fq13so2804563lab.7 for ; Thu, 04 Apr 2013 12:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:content-transfer-encoding; bh=yPRabcr/M2P4vXiESDaglDJcH5Yus4ZKS4VQsgc2waI=; b=UafLVJ7clXGLjDJlz3IwkpUoFA3BkLUyej5dKsGVKbsMEW0b7LlkLQRFzly39W0fvc zcKet7/uqMlMz4oXRaP10OUD3Zaj/B5KbgWIT61mMydSBTJVEha71ht4ScoPlc6yFdIN rtlcFEW7mH1POOSM/nV8RLRsXQnLqbyHkVKR56oYl0WQ+ya6jnhT2cJwZSR8Y/ksqUup DOkvBQXmOiJfxsor9CFh6qsc7fAAMt/HkXTuZgSdLOzsqO2GMoQ2xZMjxBjXwTnWk8Kg QZIKKDzubzOyWIVjsm7svFm18ElcKNe6B0L6sLMBNDCTXhNnHLZeOIb8ZwTvBev85xlV HdDA== MIME-Version: 1.0 X-Received: by 10.112.137.74 with SMTP id qg10mr4326984lbb.72.1365105129098; Thu, 04 Apr 2013 12:52:09 -0700 (PDT) Received: by 10.114.38.33 with HTTP; Thu, 4 Apr 2013 12:52:08 -0700 (PDT) In-Reply-To: References: <515BE6C2.7000801@sugarcrm.com> <515C9878.8060603@sugarcrm.com> <7848763017118166753@unknownmsgid> Date: Thu, 4 Apr 2013 12:52:08 -0700 Message-ID: To: Pierrick Charron Cc: Julien Pauli , Xinchen Hui , Leigh , Laruence , Stas Malyshev , Ferenc Kovacs , PHP Internals Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers From: hannes.magnusson@gmail.com (Hannes Magnusson) On Thu, Apr 4, 2013 at 11:27 AM, Pierrick Charron wrote= : > Hi > > I don't think we should remove curlwrappers from 5.5. I do agree that thi= s > is not yet stable and ready to push as non experimental, but since we pla= n > to release 5.5 soon I don't think removing it right now is worth it. > > I started some time ago to maintain the curl extension. I focused mainly = on > adding to ext/curl all options from the libcurl api that were not availab= le > in PHP userspace. I also fixed some bugs on curlwrappers and will be plea= se > to fix (or at least try to fix) all bugs that we may have with curl and c= url > wrappers in the hope that it will be stable enough to be release with php > next=C3=A9 > > If you have a bug with curlwrapper (or anything related to ext/curl) plea= se > assign me the bug on the tracker and I will try to look at them ASAP. Its not only about maintaining it. This experiment failed a long time ago. Overwriting the core streams has proven itself to be the wrong way. If there was a way for userspace to say "overload with curl" then thats fin= e. We already have a procedure for this: stream_wrapper_unregister("http"); stream_wrapper_register("http", "CurlStreamWrapper"); and then stream_wrapper_restore("http") to go back to the core streams. I would definitely see the benefits in something like that, but as things are now are simply not working and should be removed. The "real way" can be re-implemented later. -Hannes