Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66940
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain pthreads.org from 209.85.212.42 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAF+90c_TfGrMRrBGOQ83ZY-bRQGeO=iS_r4kXYdiGmm9iC800Q@mail.gmail.com>
References: <CAESVnVr_jLwRbVsOOx3urPv0Qzc9Rc-7y2CNp1T0mH+8ad3cRg@mail.gmail.com>
	<CAF+90c9N81ZoSpwm2hSh=gCYV2Y3jB1e+N4_N_d_QfHk9JPK5g@mail.gmail.com>
	<CAESVnVrAV4GwhbtUwxez4sAwPboZ1dh=vB2WcW18sv3zt3+MTQ@mail.gmail.com>
	<515C8670.7030400@php.net>
	<CAF+90c_TfGrMRrBGOQ83ZY-bRQGeO=iS_r4kXYdiGmm9iC800Q@mail.gmail.com>
Date: Thu, 4 Apr 2013 13:48:12 +0100
Message-ID: <CAL=_i_=BSyNtUcTF6JNkw7pkP+JWn3BskSde3bdDbMoZ+2sjEw@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Joe Watkins <krakjoe@php.net>, PHP internals <internals@lists.php.net>, 
	Sara Golemon <pollita@php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [RFC] Simplified Array API for extensions
From: pthreads@pthreads.org (Joe Watkins)

The idea was to avoid treating the object as an array of properties
where there is another option. Where there isn't an option the objects
properties have to be accessed as an array dont they?

On 4/4/13, Nikita Popov <nikita.ppv@gmail.com> wrote:
> On Wed, Apr 3, 2013 at 9:43 PM, Joe Watkins <krakjoe@php.net> wrote:
>
>> Hi Sara,
>>
>> A logical extension of this idea would be to drop _array_ and cover
>> objects too, one uniform everything API is very appealing, and way easier
>> to document properly.
>>
>> Something alone the lines of:
>>
>> static inline
>> zend_bool php_exists(zval *pzval, const char *key) {
>>         switch (Z_TYPE(pzval)) {
>>             case IS_ARRAY:
>>                 return zend_symtable_exists(Z_ARRVAL_**P(pzval), key,
>> strlen(key) + 1);
>>
>>             default: {
>>                 if (Z_OBJ_HT_P(pzval)->has_**property) {
>>                     return Z_OBJ_HT_P(pzval)->has_**property(
>>                         pzval, key, strlen(key) + 1, 2 NULL TSRMLS_CC
>>                     );
>>                 } else {
>>                     return zend_symtable_exists(
>>                         Z_OBJPROP_P(pzval), key, strlen(key) + 1);
>>                 }
>>             }
>>         }
>> }
>>
>> Just a thought ..
>>
>
> Strong -1 on anything that tries to treat objects as if they were arrays of
> properties. I think much damage has already been done by using object
> properties as an array in some places and we should not go further down
> that road. I have no problem with nice APIs for object properties access,
> but please, please do not mix both.
>
> Nikita
>