Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66939
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.45 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <515C8670.7030400@php.net>
References: <CAESVnVr_jLwRbVsOOx3urPv0Qzc9Rc-7y2CNp1T0mH+8ad3cRg@mail.gmail.com>
	<CAF+90c9N81ZoSpwm2hSh=gCYV2Y3jB1e+N4_N_d_QfHk9JPK5g@mail.gmail.com>
	<CAESVnVrAV4GwhbtUwxez4sAwPboZ1dh=vB2WcW18sv3zt3+MTQ@mail.gmail.com>
	<515C8670.7030400@php.net>
Date: Thu, 4 Apr 2013 12:39:21 +0200
Message-ID: <CAF+90c_TfGrMRrBGOQ83ZY-bRQGeO=iS_r4kXYdiGmm9iC800Q@mail.gmail.com>
To: Joe Watkins <krakjoe@php.net>
Cc: PHP internals <internals@lists.php.net>, Sara Golemon <pollita@php.net>
Content-Type: multipart/alternative; boundary=047d7b5d2ba45a1c0504d986957f
Subject: Re: [PHP-DEV] [RFC] Simplified Array API for extensions
From: nikita.ppv@gmail.com (Nikita Popov)

--047d7b5d2ba45a1c0504d986957f
Content-Type: text/plain; charset=ISO-8859-1

On Wed, Apr 3, 2013 at 9:43 PM, Joe Watkins <krakjoe@php.net> wrote:

> Hi Sara,
>
> A logical extension of this idea would be to drop _array_ and cover
> objects too, one uniform everything API is very appealing, and way easier
> to document properly.
>
> Something alone the lines of:
>
> static inline
> zend_bool php_exists(zval *pzval, const char *key) {
>         switch (Z_TYPE(pzval)) {
>             case IS_ARRAY:
>                 return zend_symtable_exists(Z_ARRVAL_**P(pzval), key,
> strlen(key) + 1);
>
>             default: {
>                 if (Z_OBJ_HT_P(pzval)->has_**property) {
>                     return Z_OBJ_HT_P(pzval)->has_**property(
>                         pzval, key, strlen(key) + 1, 2 NULL TSRMLS_CC
>                     );
>                 } else {
>                     return zend_symtable_exists(
>                         Z_OBJPROP_P(pzval), key, strlen(key) + 1);
>                 }
>             }
>         }
> }
>
> Just a thought ..
>

Strong -1 on anything that tries to treat objects as if they were arrays of
properties. I think much damage has already been done by using object
properties as an array in some places and we should not go further down
that road. I have no problem with nice APIs for object properties access,
but please, please do not mix both.

Nikita

--047d7b5d2ba45a1c0504d986957f--