Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66916
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.51 as permitted sender)
MIME-Version: 1.0
Sender: kalle.php@gmail.com
In-Reply-To: <CABBJUpfFeCwR_L59OsD7ZTtnL4=cNr6HW_boYneUFjKxjKVsqQ@mail.gmail.com>
References: <CABBJUpexRYZaXi10UobucCzJUXsLLK9avs+WspdSxyE4vDJ2rA@mail.gmail.com>
	<CADNQb0Uo0u2xCbR_joWKmwN9z+77nN-cLQ=Lcq2gpr0hf_A2qA@mail.gmail.com>
	<CABBJUpfx__wLqtG0w1SQzveggPiWubGLkPUJMFL+27cz3P_GyQ@mail.gmail.com>
	<CABBJUpcHuBT6schJm9gDe_tyz=Gvj53dNcs9UKbj2w040pCsiw@mail.gmail.com>
	<515BE6C2.7000801@sugarcrm.com>
	<CABBJUpfFeCwR_L59OsD7ZTtnL4=cNr6HW_boYneUFjKxjKVsqQ@mail.gmail.com>
Date: Wed, 3 Apr 2013 16:42:47 +0200
Message-ID: <CAJW__o03DBbfoWyWtJLb1cte8DzDtZazfnxJO0iwps8fjfAKgw@mail.gmail.com>
To: Laruence <laruence@php.net>
Cc: Stas Malyshev <smalyshev@sugarcrm.com>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers
From: kalle@php.net (Kalle Sommer Nielsen)

2013/4/3 Laruence <laruence@php.net>:
> On Wed, Apr 3, 2013 at 4:22 PM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:
>
>> Hi!
>>
>> > Added new constant CURL_WRAPPERS_ENABLE  in (include 5.4)
>> >
>> https://github.com/php/php-src/commit/d7f709a032a40cb475042b43db07a4698a2488b7
>>
>> I must say the process of how it was done was not very good. Not only
>> there were no substantial discussion on adding this new thing in stable
>> version before the commit, the time between message announcing it and
>> asking if there are any objections and the commit was barely a day. It's
>> not enough time at all to solicit feedback, and this change is not
>> really something urgent that needs to be committed ASAP. And it turns
>> out, there *are* objections. Could we be a little less quick with
>> commits into a stable version and give it some time when we're talking
>> about new things and not bugfixes?
>>
> Hey:
>     I have to say,  the objections only shows up after it happens..
>
>     but yes,  I am a little rush at this commit, that is because, you can
> see, the test script in ext/standard/tests/stream is depends on a ugly
> trick to skip . it make me very uncomfortable.
>
>     I send the mail the day before yesterday,  and it's really not a big
> change (add a constant),  then no new feedback in a day,  I think it's okey
> to commit.
>
>     however, you are right, it's not a long time, so if objections becomes
> strong,  I can revert it.

I think my argument against adding the constant is at least just as
strong as adding it. I agree we shouldn't go RFC/vote etc, over one
single constant but I think we can all agree on the fact that we
shouldn't try to add hacks to fix usage of an experimental feature
(which is essentially what this constant is).

We need more consistency, than inconsistencies.

-- 
regards,

Kalle Sommer Nielsen
kalle@php.net