Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66908
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <515BE6C2.7000801@sugarcrm.com>
References: <CABBJUpexRYZaXi10UobucCzJUXsLLK9avs+WspdSxyE4vDJ2rA@mail.gmail.com>
	<CADNQb0Uo0u2xCbR_joWKmwN9z+77nN-cLQ=Lcq2gpr0hf_A2qA@mail.gmail.com>
	<CABBJUpfx__wLqtG0w1SQzveggPiWubGLkPUJMFL+27cz3P_GyQ@mail.gmail.com>
	<CABBJUpcHuBT6schJm9gDe_tyz=Gvj53dNcs9UKbj2w040pCsiw@mail.gmail.com>
	<515BE6C2.7000801@sugarcrm.com>
Date: Wed, 3 Apr 2013 10:41:01 +0200
Message-ID: <CAEZPtU6zLOLhdvchN1uPbcfS4JRRpP6NKyhh7-QBwVpvEwLHqg@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: Laruence <laruence@php.net>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers
From: pierre.php@gmail.com (Pierre Joye)

On Wed, Apr 3, 2013 at 10:22 AM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Hi!
>
>> Added new constant CURL_WRAPPERS_ENABLE  in (include 5.4)
>> https://github.com/php/php-src/commit/d7f709a032a40cb475042b43db07a4698a2488b7
>
> I must say the process of how it was done was not very good. Not only
> there were no substantial discussion on adding this new thing in stable
> version before the commit, the time between message announcing it and
> asking if there are any objections and the commit was barely a day. It's
> not enough time at all to solicit feedback, and this change is not
> really something urgent that needs to be committed ASAP. And it turns
> out, there *are* objections. Could we be a little less quick with
> commits into a stable version and give it some time when we're talking
> about new things and not bugfixes?

I'd to agree. I was surprised to see a commit this morning.

Cheers,
--
Pierre

@pierrejoye