Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:66906 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 36680 invoked from network); 3 Apr 2013 08:22:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Apr 2013 08:22:30 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.67 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 108.166.43.67 smtp67.ord1c.emailsrvr.com Linux 2.6 Received: from [108.166.43.67] ([108.166.43.67:58552] helo=smtp67.ord1c.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 22/1B-07534-5C6EB515 for ; Wed, 03 Apr 2013 03:22:29 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp1.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id 8085F148101; Wed, 3 Apr 2013 04:22:27 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp1.relay.ord1c.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 3108F148072; Wed, 3 Apr 2013 04:22:27 -0400 (EDT) Message-ID: <515BE6C2.7000801@sugarcrm.com> Date: Wed, 03 Apr 2013 01:22:26 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: Laruence CC: PHP Internals References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > Added new constant CURL_WRAPPERS_ENABLE in (include 5.4) > https://github.com/php/php-src/commit/d7f709a032a40cb475042b43db07a4698a2488b7 I must say the process of how it was done was not very good. Not only there were no substantial discussion on adding this new thing in stable version before the commit, the time between message announcing it and asking if there are any objections and the commit was barely a day. It's not enough time at all to solicit feedback, and this change is not really something urgent that needs to be committed ASAP. And it turns out, there *are* objections. Could we be a little less quick with commits into a stable version and give it some time when we're talking about new things and not bugfixes? Thanks, -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227