Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66903
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAJW__o3KBcRjg-ubD_NXQYN=5RjzGEy6ACTQ4dV07Dp6QT-=bA@mail.gmail.com>
References: <CABBJUpexRYZaXi10UobucCzJUXsLLK9avs+WspdSxyE4vDJ2rA@mail.gmail.com>
	<CAJW__o3KBcRjg-ubD_NXQYN=5RjzGEy6ACTQ4dV07Dp6QT-=bA@mail.gmail.com>
Date: Wed, 3 Apr 2013 00:40:52 -0700
Message-ID: <CADNQb0VxUew2D6M9==j0rDJiAJBE2E5CYh-4ssgPLKXNo8Unjg@mail.gmail.com>
To: Kalle Sommer Nielsen <kalle@php.net>
Cc: Laruence <laruence@php.net>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers
From: hannes.magnusson@gmail.com (Hannes Magnusson)

On Wed, Apr 3, 2013 at 12:31 AM, Kalle Sommer Nielsen <kalle@php.net> wrote:
> Hi Laruence
>
> 2013/3/31 Laruence <laruence@php.net>
>>    I propose to add a constant : bool CURL_WRAPPERS_ENABLE
>>
>>    or, any other better name...
>>
>>    objections?
>
> I'm a -1 on this, because as we sort of agreed on (like Hannes
> implied), this experimental feature did not turn out as we wanted, its
> buggy and nobody maintains it. Currently to figure out if PHP was
> built with curlwrappers, theres this dirty hack by printing the
> phpinfo() page into an output buffer, to parse it for the build
> string, this sucks.
>
> However, since this is an experimental feature, we should either:
> 1) Make it work (most unlikely)
> 2) Remove it
>
> Instead of adding tiny hacks to make it easier (I know a constant wont
> hurt much). Cross version code is also gonna end up with even more
> clutter, imagine this (if you want to utilize this new constant, which
> is the idea right?):
>
> $curlwrappers = false;
>
> if(defined('CURL_WRAPPERS_ENABLED')) {
>  $curlwrappers = true;



You'll actually have to assign the value of CURL_WRAPPERS_ENABLED to
$curlwrappers, as defined() only checks if the constant exist.. not if
its set to true :)

-Hannes